Skip to content

Commit

Permalink
HCK-9651, HCK-9652, HCK-9659: fix issues related to type selector in …
Browse files Browse the repository at this point in the history 
…GraphQL (#46)

* enable disabled tests

* add enhanced configs for types in arguments properties
  • Loading branch information
@VitaliiBedletskyi
VitaliiBedletskyi authored Jan 28, 2025
1 parent 0028319 commit c44dc0c
Show file tree
Hide file tree
Showing 2 changed files with 170 additions and 14 deletions.
180 changes: 168 additions & 12 deletions properties_pane/field_level/fieldLevelConfig.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1369,7 +1369,20 @@ making sure that you maintain a proper JSON format.
},
"options": {
"useAllDefinitionsAsSource": true,
"includeTargetTypes": true
"groupBy": "childType",
"includeTargetTypes": {
"excludeTypes": [
"List",
"enum",
"input",
"scalar",
"union",
"object",
"interface",
"union",
"directive"
]
}
}
}
}
Expand Down Expand Up @@ -1482,7 +1495,20 @@ making sure that you maintain a proper JSON format.
},
"options": {
"useAllDefinitionsAsSource": true,
"includeTargetTypes": true
"groupBy": "childType",
"includeTargetTypes": {
"excludeTypes": [
"List",
"enum",
"input",
"scalar",
"union",
"object",
"interface",
"union",
"directive"
]
}
}
}
}
Expand Down Expand Up @@ -1595,7 +1621,20 @@ making sure that you maintain a proper JSON format.
},
"options": {
"useAllDefinitionsAsSource": true,
"includeTargetTypes": true
"groupBy": "childType",
"includeTargetTypes": {
"excludeTypes": [
"List",
"enum",
"input",
"scalar",
"union",
"object",
"interface",
"union",
"directive"
]
}
}
}
}
Expand Down Expand Up @@ -1708,7 +1747,20 @@ making sure that you maintain a proper JSON format.
},
"options": {
"useAllDefinitionsAsSource": true,
"includeTargetTypes": true
"groupBy": "childType",
"includeTargetTypes": {
"excludeTypes": [
"List",
"enum",
"input",
"scalar",
"union",
"object",
"interface",
"union",
"directive"
]
}
}
}
}
Expand Down Expand Up @@ -1821,7 +1873,20 @@ making sure that you maintain a proper JSON format.
},
"options": {
"useAllDefinitionsAsSource": true,
"includeTargetTypes": true
"groupBy": "childType",
"includeTargetTypes": {
"excludeTypes": [
"List",
"enum",
"input",
"scalar",
"union",
"object",
"interface",
"union",
"directive"
]
}
}
}
}
Expand Down Expand Up @@ -1934,7 +1999,20 @@ making sure that you maintain a proper JSON format.
},
"options": {
"useAllDefinitionsAsSource": true,
"includeTargetTypes": true
"groupBy": "childType",
"includeTargetTypes": {
"excludeTypes": [
"List",
"enum",
"input",
"scalar",
"union",
"object",
"interface",
"union",
"directive"
]
}
}
}
}
Expand Down Expand Up @@ -2048,7 +2126,20 @@ making sure that you maintain a proper JSON format.
},
"options": {
"useAllDefinitionsAsSource": true,
"includeTargetTypes": true
"groupBy": "childType",
"includeTargetTypes": {
"excludeTypes": [
"List",
"enum",
"input",
"scalar",
"union",
"object",
"interface",
"union",
"directive"
]
}
}
}
}
Expand Down Expand Up @@ -2171,7 +2262,20 @@ making sure that you maintain a proper JSON format.
},
"options": {
"useAllDefinitionsAsSource": true,
"includeTargetTypes": true
"groupBy": "childType",
"includeTargetTypes": {
"excludeTypes": [
"List",
"enum",
"input",
"scalar",
"union",
"object",
"interface",
"union",
"directive"
]
}
}
}
}
Expand Down Expand Up @@ -2294,7 +2398,20 @@ making sure that you maintain a proper JSON format.
},
"options": {
"useAllDefinitionsAsSource": true,
"includeTargetTypes": true
"groupBy": "childType",
"includeTargetTypes": {
"excludeTypes": [
"List",
"enum",
"input",
"scalar",
"union",
"object",
"interface",
"union",
"directive"
]
}
}
}
}
Expand Down Expand Up @@ -2417,7 +2534,20 @@ making sure that you maintain a proper JSON format.
},
"options": {
"useAllDefinitionsAsSource": true,
"includeTargetTypes": true
"groupBy": "childType",
"includeTargetTypes": {
"excludeTypes": [
"List",
"enum",
"input",
"scalar",
"union",
"object",
"interface",
"union",
"directive"
]
}
}
}
}
Expand Down Expand Up @@ -2525,7 +2655,20 @@ making sure that you maintain a proper JSON format.
},
"options": {
"useAllDefinitionsAsSource": true,
"includeTargetTypes": true
"groupBy": "childType",
"includeTargetTypes": {
"excludeTypes": [
"List",
"enum",
"input",
"scalar",
"union",
"object",
"interface",
"union",
"directive"
]
}
}
}
}
Expand Down Expand Up @@ -2632,7 +2775,20 @@ making sure that you maintain a proper JSON format.
},
"options": {
"useAllDefinitionsAsSource": true,
"includeTargetTypes": true
"groupBy": "childType",
"includeTargetTypes": {
"excludeTypes": [
"List",
"enum",
"input",
"scalar",
"union",
"object",
"interface",
"union",
"directive"
]
}
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions test/forward_engineering/mappers/arguments.spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ describe('getArguments', () => {
strictEqual(result, '(arg1: String, arg2: Int)');
});

it.skip('should return formatted arguments if descriptions are present', () => {
it('should return formatted arguments if descriptions are present', () => {
const graphqlArguments = [
{ name: 'arg1', type: 'String', description: 'Argument description 1' },
{ name: 'arg2', type: 'Int', description: 'Argument description 2' },
Expand All @@ -176,7 +176,7 @@ describe('getArguments', () => {
strictEqual(result, '(arg1: String, arg2: Int)');
});

it.skip("should skip arguments which don't have name or type or both", () => {
it("should skip arguments which don't have name or type or both", () => {
const graphqlArguments = [
{ type: 'String' }, // missing name
{ name: 'arg2' }, // missing type
Expand Down

0 comments on commit c44dc0c

Please sign in to comment.