Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCK-7285: missing column type #39

Merged

Conversation

chulanovskyi-bs
Copy link
Contributor

@chulanovskyi-bs chulanovskyi-bs commented Jul 18, 2024

TaskHCK-7275 Close model after releasing license key

Technical details

  • handle the missing Type of the column, setting the 'string' as a fallback

Copy link

@VitaliiBedletskyi VitaliiBedletskyi merged commit 06fd128 into feat/HCK-3126-glue-client Jul 18, 2024
2 checks passed
@VitaliiBedletskyi VitaliiBedletskyi deleted the fix/HCK-7285-missing-column-type branch July 18, 2024 10:56
github-merge-queue bot pushed a commit that referenced this pull request Jul 18, 2024
* feat: replaced aws sdk with direct glue client package

* fix: handle the missing Type of the column (#39)

* HCK-7258: fetch-http-handler (#40)

* feat: added fetch-http-handler

* chore: move HttpHandler to its own place
@Vitalii4as Vitalii4as changed the title HCK-7275: missing column type HCK-7285: missing column type Jul 25, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 30, 2024
* feat: replaced aws sdk with direct glue client package

* fix: handle the missing Type of the column (#39)

* feat: added fetch-http-handler

* chore: move HttpHandler to its own place

* temp: skeleton for a controller

* feat: replaced @aws-sdk/fetch-http-handler with own HttpHandler that uses electron.net.fetch explicitly

* chore: refactored lodash dependency usage

* chore: removed `@aws-sdk/fetch-http-handler` package

* feat: start using own request handler in FE

* chore: use lodash discreetly

* fix: declared `electron` as external package

* chore: declared `electron` as peer dependency

* fix: preserve error trace in reject

* Update shared/httpHandler/httpHandler.js

Co-authored-by: Ugo Bechameil <ugo.bechameil@hackolade.com>

* chore: replace Promise.reject with a throw statement

* fix: replaced own implementation of query builder with native URLSearchParams

* chore: made the contract more explicit

* chore: updated package-lock.json

---------

Co-authored-by: Ugo Bechameil <ugo.bechameil@hackolade.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants