Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change boot option to manual_only #11

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

tjorim
Copy link
Contributor

@tjorim tjorim commented Sep 5, 2024

Add-on should never start at boot, prevents users from changing it. home-assistant/supervisor#5272

Copy link

coderabbitai bot commented Sep 5, 2024

📝 Walkthrough

Walkthrough

The configuration settings in the get/config.yaml file have been updated, specifically changing the boot parameter from manual to manual_only. This change ensures the add-on operates strictly in manual mode, eliminating any chance of automatic startup. Think of it as telling the add-on, "You can only wake up when I say so!"—no more surprise wake-up calls!

Changes

File Change Summary
get/config.yaml boot: manual changed to boot: manual_only

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Add-on

    User->>Add-on: Start Add-on
    Add-on-->>User: Booting up (manual_only mode)
    User->>Add-on: Perform Action
    Add-on-->>User: Action Completed
Loading

And there you have it! Just like a cat that only wants to be petted when it feels like it, this add-on now only starts when you want it to! 🐱✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ludeeus
Copy link
Member

ludeeus commented Sep 5, 2024

Why should it not?

Personally i have it to start on boot to grab the latest dev build.

@tjorim
Copy link
Contributor Author

tjorim commented Sep 5, 2024

I guess that's a valid use case but aren't you always running a version behind that way? Does startup: once ensure the add-on runs before HA? When you reboot your system, HA starts, add-on runs and pulls the latest version. Don't you need to restart HA itself again to make it active?

@ludeeus
Copy link
Member

ludeeus commented Sep 5, 2024

Hmmm.... good point, maybe my use-case is flawed 😄

@ludeeus
Copy link
Member

ludeeus commented Sep 5, 2024

Okey, it was flawed.
So this should probably be included.
But will have to wait until then supervisor has been released to stable (and the linter support it).

@tjorim tjorim mentioned this pull request Sep 10, 2024
Add-on should never start at boot, prevents users from changing it.
home-assistant/supervisor#5272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants