-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct __init__ filename in publish instructions #599
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request focuses on refining the Changes
Possibly related PRs
Suggested reviewers
And remember, if you ever feel down, just think of a Python file that’s named wrong—it’s not a bug, it’s a feature! Keep those names straight! 🐍 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (1)
source/docs/publish/integration.md
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/docs/publish/integration.md
[uncategorized] ~27-~27: Possible missing comma found.
Context: ...
README.md
hacs.json
#### Not OK example (1):
awesome/init.p...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~37-~37: Possible missing comma found.
Context: ...e/hacs.json
README.md
#### Not OK example (2):
init.py
senso...
(AI_HYDRA_LEO_MISSING_COMMA)
🪛 Markdownlint (0.35.0)
source/docs/publish/integration.md
27-27: Punctuation: ':'
Trailing punctuation in heading
(MD026, no-trailing-punctuation)
37-37: Punctuation: ':'
Trailing punctuation in heading
(MD026, no-trailing-punctuation)
29-29: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
39-39: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🔇 Additional comments (2)
source/docs/publish/integration.md (2)
20-24
: Looking sharp with that double underscore! 🐍
The __init__.py
filename is now correctly formatted. As they say in Python circles, two underscores are better than one! This matches the standard Python module structure.
Line range hint 1-44
: Documentation is as clean as a freshly formatted hard drive! 💾
The structure is clear, examples are well-organized, and the requirements are thoroughly documented. The correction of the __init__.py
filename makes this documentation more accurate and reliable.
🧰 Tools
🪛 LanguageTool
[formatting] ~17-~17: Insert a comma after ‘OK’.
Context: ...omponents/INTEGRATION_NAME/`.
OK example:
custom_components/awes...
(SENT_START_THANKS_COMMA)
---
[uncategorized] ~27-~27: Possible missing comma found.
Context: ...
README.md
hacs.json
Not OK example (1):
awesome/__init__.p...
(AI_HYDRA_LEO_MISSING_COMMA)
---
[uncategorized] ~37-~37: Possible missing comma found.
Context: ...e/hacs.json
README.md
Not OK example (2):
__init__.py
senso...
(AI_HYDRA_LEO_MISSING_COMMA)
</details>
<details>
<summary>🪛 Markdownlint (0.35.0)</summary>
17-17: Punctuation: ':'
Trailing punctuation in heading
(MD026, no-trailing-punctuation)
---
27-27: Punctuation: ':'
Trailing punctuation in heading
(MD026, no-trailing-punctuation)
---
37-37: Punctuation: ':'
Trailing punctuation in heading
(MD026, no-trailing-punctuation)
---
19-19: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
---
29-29: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
---
39-39: null
Fenced code blocks should have a language specified
(MD040, fenced-code-language)
---
47-47: Expected: asterisk; Actual: underscore
Emphasis style
(MD049, emphasis-style)
---
47-47: Expected: asterisk; Actual: underscore
Emphasis style
(MD049, emphasis-style)
</details>
</details>
</details>
</details>
</details>
<!-- This is an auto-generated comment by CodeRabbit for review status -->
The review tool is asking for changes that feel out of the scope of this PR. I'll make them if you want but I'm not trying to touch the structure, just the content. |
Fixed the filename for python's init.
I'm not sure if the single underscore was originally to stop markdown from underlining or something, but I think in the code quote block it should be ok?