-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace haddock3-analysis-components with haddock3-ui package #1025
Conversation
To which extend we could also ship the haddock3-ui when installing haddock3, so the |
Working on offline mode in i-VRESSE/haddock3-ui#9 .
|
Good question! design choice I guess.
@rvhonorato , @amjjbonvin please provide input for this |
How large is the js file?
|
The js file is 1.5Mb and the css file 11Kb. @VGPReys indeed I was thinking of making it part of the haddock3 installation (using a similar mechanism as used to download cns executables in #1013) and then during analysis copy the css+js files to the run_dir, as the web server must have the css+js files in the directory it is hosting. |
Offline exampleIn examples/scoring dir created capri-scoring-test.offline.cfg with # ===================================================================================
# CAPRI Scoring example
# ===================================================================================
# The Critical Assessment of PRedicted Interactions (CAPRI) experiment
# aims to do test methods that model macromolecular interactions in
# blind predictions based on the three-dimensional structures of proteins.
# For more information, please visit: https://www.ebi.ac.uk/pdbe/complex-pred/capri/
# ===================================================================================
run_dir = "capriscoring-test"
# execution mode
ncores = 40
mode = "local"
offline = true
# molecules to be scored (an ensemble PBD)
molecules = "data/T161-rescoring-ens.pdb"
# ===================================================================================
[topoaa]
[emscoring]
[caprieval]
[clustfcc]
min_population = 2
[seletopclusts]
top_cluster = 1
top_models = 2
[mdscoring]
per_interface_scoring = true
[clustfcc]
min_population = 2
[seletopclusts]
[caprieval]
# ===================================================================================
Ran with rm -r capriscoring-test
haddock3 capri-scoring-test.offline.cfg
mkdir capriscoring-test/data/ui
curl -o capriscoring-test/data/ui/report.bundle.js https://cdn.jsdelivr.net/npm/@i-vresse/haddock3-ui@~0.3.0/dist/report.bundle.js
curl -o capriscoring-test/data/ui/index.css https://cdn.jsdelivr.net/npm/@i-vresse/haddock3-ui@~0.3.0/dist/index.css |
@rvhonorato At #1025 (comment) I am working on rendering tables in offline mode. To do that I need to copy a css and js file from the haddock3 installation. How can we make those files part of the haddock3 installation? I see several options:
What has your preference? |
I went for option 2 so a 1.5Mb js file will be part of the repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both unclustered and clustered tables look good!
Fixed with i-VRESSE@d24a510 |
``` pip install build python3 -m build . ```
You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines.
Checklist
Summary of the Pull Request
I made 2 npm packages
The
haddock3-ui
package now can do everything thehaddock3-analysis-components
can do. So I want to archive thehaddock3-analysis-components
GitHub repo.This PR uses the haddock3-ui package for rendering tables of clusters and structures.
This PR also implements offline mode for the table in the report.html, no urls outside the local web server are requested.
Related Issue
i-VRESSE/haddock3-ui#6
Additional Info