Skip to content

Removing analysis steps on run restart#1509

Merged
VGPReys merged 9 commits intomainfrom
analysis-restart
Apr 11, 2026
Merged

Removing analysis steps on run restart#1509
VGPReys merged 9 commits intomainfrom
analysis-restart

Conversation

@VGPReys
Copy link
Copy Markdown
Contributor

@VGPReys VGPReys commented Apr 10, 2026

Checklist

  • Tests added for the new code
  • Documentation added for the code changes
  • Modifications / enhancements are reflected on the haddock3 user-manual
  • CHANGELOG.md is updated to incorporate new changes
  • Does not break licensing
  • Does not add any dependencies, if it does please add a thorough explanation

Summary of the Pull Request

This PR solves the issue of not recomputing analyses when restarting a run.
Now, all analysis directories with number >= restart module id are removed, therefore triggering the analysis of downstream modules with restart settings.
Also removes the traceback folder to make sure it is recomputed

Related Issue

#1495

Additional Info

@VGPReys VGPReys requested a review from AnnaEngel98 April 10, 2026 11:41
@VGPReys VGPReys self-assigned this Apr 10, 2026
@VGPReys VGPReys added the bug Something isn't working label Apr 10, 2026
Copy link
Copy Markdown
Member

@amjjbonvin amjjbonvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do remove also the traceback folder if not already happening.

@VGPReys VGPReys requested a review from amjjbonvin April 11, 2026 11:28
@VGPReys VGPReys changed the title Removing analysis steps on run restart from Removing analysis steps on run restart Apr 11, 2026
@VGPReys VGPReys enabled auto-merge April 11, 2026 14:10
Copy link
Copy Markdown
Member

@amjjbonvin amjjbonvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as a charm

@VGPReys VGPReys merged commit 8ecc6ea into main Apr 11, 2026
10 checks passed
@VGPReys VGPReys deleted the analysis-restart branch April 11, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants