Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify definition of counted parameters by computing them on the fly from definition. #975

Merged
merged 16 commits into from
Sep 23, 2024

Conversation

VGPReys
Copy link
Contributor

@VGPReys VGPReys commented Aug 14, 2024

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:

  • You have sticked to Python. Please talk to us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there is a (state) purpose
  • Your code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any dependencies, unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

A solution to compute on the fly counted parameters, such as:

  • nfle
  • nncs (previously known as numncs)
  • ncXsym (previously known as numcXsym)
  • nsXsym (previously known as numsXsym)

Allows to remove one parameter from user configuration files.
Parameters are (and must still be) present in the defaults.yaml as hidden expertise level.

Related to #919
Closes #1029

@rvhonorato
Copy link
Member

Check if this goes before, after or if it does not matter -> #969

@VGPReys
Copy link
Contributor Author

VGPReys commented Aug 22, 2024

Does not matter.
Could be merged before, as quite related.

@amjjbonvin
Copy link
Member

Related to issue #919

Base automatically changed from flexseg to main September 12, 2024 15:08
@VGPReys VGPReys requested a review from a team September 17, 2024 10:27
@VGPReys VGPReys added yaml default parameters Anything related to the YAML configuration files for default parameters CNS Improvements in the CNS engine labels Sep 17, 2024
@VGPReys VGPReys changed the title Flexseg onthefly nfle Simplify definition of counted parameters by computing them on the fly from definition. Sep 17, 2024
Co-authored-by: Anna Engel <113177776+AljaLEngel@users.noreply.github.com>
@AljaLEngel AljaLEngel requested a review from a team September 17, 2024 11:58
Co-authored-by: Anna Engel <113177776+AljaLEngel@users.noreply.github.com>
sverhoeven added a commit to i-VRESSE/workflow-builder that referenced this pull request Sep 20, 2024
@sverhoeven
Copy link
Contributor

Tried it out in the workflow builder, in the preview looks much cleaner when guru catalog is selected, emref is node is added and symmetry fieldset is expanded.

@VGPReys VGPReys merged commit c6b3f99 into main Sep 23, 2024
4 checks passed
@VGPReys VGPReys deleted the flexseg-onthefly-nfle branch September 23, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CNS Improvements in the CNS engine yaml default parameters Anything related to the YAML configuration files for default parameters
Projects
Development

Successfully merging this pull request may close these issues.

Simplify definition of counted parameters
5 participants