HDS shift some config to env-vars #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # deployments/haikudepotserver.yml
andponlin
force-pushed
the
hds-env-vars-oct2025
branch
from
0d247ee to
0f14fd9
Compare
|
I have generated the |
|
The new config has been applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The situation with configs has been a bit messy in HDS owing to history. There are some defaults in code, some values baked into the build product, some are in an additional config file that is inserted in the Docker image build and some are provided by env-vars.
I am going to be trying to get all of the config variables defined in the build-product config or env-vars to clean this up. This PR brings in a few new env-vars to the
Deploymentin preparation for an upcoming release.NOTE this change assumes the presence of a new secret for the env-var
HDS_AUTHENTICATION_JWS_SHARED_KEY. You will need to create this secret. The string value should be some arbitrary UUID. This was value was previously re-generated each time HDS started up, but in the future for active:active redundancy (multiple Pods), this value will need to be consistent across Pods.