Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort the output of --list-dependencies. #312

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OscarL
Copy link
Contributor

@OscarL OscarL commented Jan 7, 2025

Had this small patch lying around for too long.

Makes reading/comparing the output --list-dependencies easier.

@Begasus
Copy link
Contributor

Begasus commented Jan 7, 2025

LGTM, list is sorted which makes it indeed easier to read. I'm just confused (but I think I already mentioned that a while back at IRC) about the actual list produced. :)

@OscarL
Copy link
Contributor Author

OscarL commented Jan 7, 2025

It lists all the packages that would need to be created if you don't use --get-depedencies...

In that case, you either need to have the needed packages already present on HaikuPorter's $PACKAGE_DIR... or they need to be built from sources before being able to build the package you used when calling hp --list-dependencies <package_name>.

At least that's my understanding.

@Begasus
Copy link
Contributor

Begasus commented Jan 7, 2025

Like: I'm seeing uchardet_x86 when I run this on hp tiff_x86 --list-dependencies, I don't get why or how uchardet would be a dependency for tiff, for other packages maybe, but still ... ends up in a pit hole.

@OscarL
Copy link
Contributor Author

OscarL commented Jan 7, 2025

AFAICS... --list-depedencies lists all the direct and indirect build-requirements, so you get this long beast.

uchardet is required by groff, and the latter is required by cmd:man (among others). git requires cmd:man, and so on.

Maybe it should be named --list-build-dependencies (and the message dependencies of $packageName-$packageVersion changed to add "build" in front). The same goes for --get-dependencies then.

@Begasus
Copy link
Contributor

Begasus commented Jan 7, 2025

AFAICS... --list-depedencies lists all the direct and indirect build-requirements, so you get this long beast.

I get that, but fwiw, I never found it something useful to check out, underlying dependencies should be shown there, my 2 cents.

Anyway, for it's purpose this looks fine to me. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants