Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Updated application versions for 5.1.0 release #89

Merged
merged 30 commits into from
Mar 4, 2024

Conversation

emanuelaepure10
Copy link
Contributor

No description provided.

florianesser and others added 28 commits July 7, 2020 16:18
This reuses the functionality found in the command for the
transformation.

SVC-516
Use latest hale studio snapshot builds.

ING-2671
uploadArchive task was removed during migration
it is now added back.

ING-3775
…Archives-task

fix for upload archives and Gradle docker plugin
switching to jre-jammy as the use pf Alpine as the OS
of the hale-cli image breaks derived images that expect Ubuntu

ING-3775
…e-to-to-jre-jammy

fixup! build: update baseImage to java 17 for Gradle docker plugin
…to-docker-plugin

build: apply jvmArgs to docker plugin
Restores the task `dockerCopyDistResources` that was present in earlier
versions of gradle-docker-plugin.

Since the upgrade of gradle-docker-plugin, the hale-cli dist version assembled
by the application plugin was no longer added to the `/hale` directory of the
created Docker image. This functionality is restored here.

SVC-1398
Apart from the updated offline resources fixes issues with Zip file
verification in newer Java version builds.

ING-4068
@florianesser
Copy link
Member

@emanuelaepure10 The change log would need to be updated before the release.

@emanuelaepure10
Copy link
Contributor Author

@florianesser Thank you for bringing this to my attention. I'll make the necessary updates immediately.

Copy link
Member

@stempler stempler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comments on the changelog.

It would be good if you would create a separate commit for the changes to the changelog and the version changes, since you mentioned you want to cherry-pick the changelog changes to the devel branch.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@emanuelaepure10 emanuelaepure10 changed the title Releasing version 5.1.0 coincides with the launch of hale»studio 5.1.0 build: Updated application versions for 5.1.0 release Mar 3, 2024
Copy link
Member

@stempler stempler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the commit messages of your two commits:

build: Updated application versions for 5.1.0 release

Updated application versions for 5.1.0 release

In this commit no longer versions are changed but the changelog updated.
Also it does not follow the commit conventions (upper case and past tense).

build: update hale and hale-cli SNAPSHOT

Update the haleVersion and hale-cli version to '5.2.0-SNAPSHOT'

ING-4011

This is not correct as the commit actually changes the versions to release versions.

CHANGELOG.md Outdated Show resolved Hide resolved
Update changelog for the 5.1.0 release
Update the haleVersion and hale-cli version to release version '5.1.0'

ING-4011
@stempler stempler merged commit 3f1388b into halestudio:master Mar 4, 2024
1 check passed
@stempler
Copy link
Member

stempler commented Mar 4, 2024

@emanuelaepure10 Build was successful: https://builds.wetransform.to/job/hale/job/hale-cli%7Epublish/540/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants