Skip to content

Apply version constraints to iOS objects #8546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexreinking merged 1 commit into from
Jan 12, 2025
Merged

Apply version constraints to iOS objects #8546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/LLVM_Runtime_Linker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,10 +423,16 @@ std::optional<llvm::VersionTuple> get_os_version_constraint(const llvm::Triple &
return std::nullopt;
}

if (triple.getOS() == llvm::Triple::MacOSX && triple.getArch() == llvm::Triple::x86_64) {
// At time of writing (June 2024), this is one version prior
if (triple.isMacOSX() && triple.isX86()) {
// At time of writing (January 2025), this is one version prior
// to the oldest version still supported by Apple.
return llvm::VersionTuple(11, 0, 0);
return llvm::VersionTuple(12, 0, 0);
}

if (triple.isiOS()) {
// At time of writing (January 2025), this is one version prior
// to the oldest version still supported by Apple.
return llvm::VersionTuple(17, 0, 0);
}

llvm::VersionTuple t = triple.getMinimumSupportedOSVersion();
Expand Down