Skip to content

Fix documentation inconsistencies from PR #3 review#5

Merged
halilc4 merged 2 commits intodevfrom
copilot/sub-pr-3
Jan 26, 2026
Merged

Fix documentation inconsistencies from PR #3 review#5
halilc4 merged 2 commits intodevfrom
copilot/sub-pr-3

Conversation

Copy link
Contributor

Copilot AI commented Jan 26, 2026

Addresses review feedback from PR #3 identifying outdated documentation and debug logs left in production code.

Documentation fixes

  • docs/DESIGN.md: Updated mixins table to match actual _mixins.scss exports (removed non-existent flex-row, flex-col, interactive-card; added form-label, btn-base, btn-ghost, btn-primary, icon-btn-sm)
  • docs/DESIGN.md + CLAUDE.md: Migrated examples from deprecated @import to @use '../styles/index' as *; pattern
  • README.md: Removed "custom title" from per-pane features (field was removed in S1 redesign)
  • README.md: Updated Quick Start step 4 to current interaction model (click pane vs hover + edit icon)

Code cleanup

  • workspaceList.component.ts: Removed 3 debug console.log() statements from createWorkspace()

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI mentioned this pull request Jan 26, 2026
4 tasks
Co-authored-by: halilc4 <6174523+halilc4@users.noreply.github.com>
@halilc4 halilc4 self-requested a review January 26, 2026 13:59
@halilc4 halilc4 marked this pull request as ready for review January 26, 2026 13:59
@halilc4 halilc4 merged commit 711f168 into dev Jan 26, 2026
@halilc4 halilc4 deleted the copilot/sub-pr-3 branch January 26, 2026 14:00
Copilot AI restored the copilot/sub-pr-3 branch January 26, 2026 14:00
Copilot AI changed the title [WIP] Release version 0.2.0 with UI redesign and bug fixes Fix documentation inconsistencies from PR #3 review Jan 26, 2026
Copilot stopped work on behalf of halilc4 due to an error January 26, 2026 14:00
@halilc4 halilc4 deleted the copilot/sub-pr-3 branch January 26, 2026 14:56
halilc4 added a commit that referenced this pull request Feb 16, 2026
- #1: Rebased on dev to resolve version mismatch (0.2.0 → 0.2.4)
- #2: Reduced DOM hacking — removed redundant host/tabPane styles, added ngOnDestroy cleanup
- #3: Replaced hardcoded #1e1e1e with $fallback-bg-more variable and CSS var fallback
- #4: Compensated for resize handle width in ratio calculation
- #5: Added W:/H: labels to pane dimension display
- #6: Smart toggle — click keeps selection, toggles editor visibility

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants