Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use task list for issue and pr checks #7011

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR use task list for issue and pr checks.

See https://github.com/orgs/halo-dev/discussions/7001 for more.

Which issue(s) this PR fixes:

Fixes https://github.com/orgs/halo-dev/discussions/7001

Does this PR introduce a user-facing change?

None

Signed-off-by: JohnNiang <johnniang@foxmail.com>
@f2c-ci-robot f2c-ci-robot bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. labels Nov 7, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and LIlGG November 7, 2024 12:31
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.24%. Comparing base (eff73dc) to head (34daba1).
Report is 49 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7011      +/-   ##
============================================
+ Coverage     56.99%   57.24%   +0.24%     
- Complexity     3999     4008       +9     
============================================
  Files           714      712       -2     
  Lines         24110    24144      +34     
  Branches       1585     1590       +5     
============================================
+ Hits          13742    13821      +79     
+ Misses         9756     9709      -47     
- Partials        612      614       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2024
@ruibaby
Copy link
Member

ruibaby commented Nov 8, 2024

这样改本质上还是 Markdown 内容,不能阻止表单提交,可以考虑直接用 checkboxes,参考:https://docs.github.com/zh/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms

比如 Docusaurus 的 issue 表单

image

Signed-off-by: JohnNiang <johnniang@foxmail.com>
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2024
Signed-off-by: JohnNiang <johnniang@foxmail.com>
@JohnNiang
Copy link
Member Author

Please test from https://github.com/JohnNiang/halo/issues/new/choose.

Copy link

sonarcloud bot commented Nov 8, 2024

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERY GOOD, MAKE HALO GREAT AGAIN.

/lgtm

image

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2024
Copy link

f2c-ci-robot bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 85b615e into halo-dev:main Nov 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants