-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use task list for issue and pr checks #7011
Use task list for issue and pr checks #7011
Conversation
Signed-off-by: JohnNiang <johnniang@foxmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7011 +/- ##
============================================
+ Coverage 56.99% 57.24% +0.24%
- Complexity 3999 4008 +9
============================================
Files 714 712 -2
Lines 24110 24144 +34
Branches 1585 1590 +5
============================================
+ Hits 13742 13821 +79
+ Misses 9756 9709 -47
- Partials 612 614 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
这样改本质上还是 Markdown 内容,不能阻止表单提交,可以考虑直接用 checkboxes,参考:https://docs.github.com/zh/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms 比如 Docusaurus 的 issue 表单: |
Signed-off-by: JohnNiang <johnniang@foxmail.com>
Signed-off-by: JohnNiang <johnniang@foxmail.com>
Please test from https://github.com/JohnNiang/halo/issues/new/choose. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR use task list for issue and pr checks.
See https://github.com/orgs/halo-dev/discussions/7001 for more.
Which issue(s) this PR fixes:
Fixes https://github.com/orgs/halo-dev/discussions/7001
Does this PR introduce a user-facing change?