Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When tarball is created with a long filename with size of 512 or multiples of 512, GNU tar is raising tar: A lone zero block at #47

Closed
wants to merge 1 commit into from
Closed

When tarball is created with a long filename with size of 512 or multiples of 512, GNU tar is raising tar: A lone zero block at #47

wants to merge 1 commit into from

Conversation

bv-vijay
Copy link

@bv-vijay bv-vijay commented Aug 25, 2023 •
edited by halostatue
Loading

This change is Reviewable

@halostatue
Copy link
Owner

Can we add a unit test for this?

@halostatue
Copy link
Owner

Please rebase against main; I modified the CI behaviour some because truffleruby+graalvm-head has turned out to be fairly unstable and we can’t see the results of the tests based on this.

@bv-vijay
Copy link
Author

bv-vijay commented Aug 26, 2023 •
edited
Loading

@halostatue I have rebased it against main. To write a valid test case, We need to fix the reader(#46). I will fix the reader first and then update the test case here.

@halostatue
Copy link
Owner

@bv-vijay Did you ever get a chance to fix the Reader issue, or can you provide a sample tarball that exhibits the error on #46 so that I can examine it?

@halostatue halostatue mentioned this pull request Jul 22, 2024
Closed
@halostatue halostatue changed the base branch from main to properly-handle-gnutar-long-reads August 6, 2024 20:16
@halostatue
Copy link
Owner

We have a resolution for #46 with #49. Based on investigations, I will be merging this after #49 and then I will release 0.12.

@halostatue halostatue deleted the branch halostatue:properly-handle-gnutar-long-reads August 6, 2024 20:24
@halostatue halostatue closed this Aug 6, 2024
halostatue added a commit that referenced this pull request Aug 6, 2024
@halostatue
fix: Write very long filenames in GNUtar format correctly
19d7ba5 
Closes: #45
Closes: #47
@halostatue halostatue mentioned this pull request Aug 6, 2024
Merged
halostatue added a commit that referenced this pull request Aug 6, 2024
@halostatue
fix: Write very long filenames in GNUtar format correctly
a63548b 
Closes: #45
Closes: #47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bv-vijay @halostatue