Skip to content

Commit

Permalink
Build libffi with -fvisibility=hidden.
Browse files Browse the repository at this point in the history
We're linking libffi statically. Without visibility=hidden, then can
result in name clashes with other versions of libffi that are pulled in
as transitive dependencies of random other libraries.
  • Loading branch information
rschatz committed Jun 18, 2024
1 parent 45b9338 commit 2029e03
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion truffle/mx.truffle/mx_truffle.py
Original file line number Diff line number Diff line change
Expand Up @@ -1571,7 +1571,7 @@ def getArchivableResults(self, use_relpath=True, single=False):
configure_args = ['--disable-dependency-tracking',
'--disable-shared',
'--with-pic',
' CFLAGS="{}"'.format(' '.join(['-g', '-O3'] + (['-m64'] if mx.get_os() == 'solaris' else []))),
' CFLAGS="{}"'.format(' '.join(['-g', '-O3', '-fvisibility=hidden'] + (['-m64'] if mx.get_os() == 'solaris' else []))),
'CPPFLAGS="-DNO_JAVA_RAW_API"',
]

Expand Down

0 comments on commit 2029e03

Please sign in to comment.