Implement hash load balancing method #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new hash load balancing method to resty.upstream.socket. This hash is a CRC32 of the given key modulo the sum of weights of available hosts. 'Available hosts' are determined before a connection attempt is made, so that host weights can be taken into account when deriving the hash. This stands in contrast to the existing round robin implementation, which walks the entire list of host and then checks its availability after making a weighted decision. Hash keys can be provided by an optional param to upstream:connect(). It would make more sense to provide a function to derive the key as part of defining the pool, but because pools are serialized as JSON, this is a no-go. See issue hamishforbes#12 for the initial discussion regarding additional load balancing schemes.
|
Cool! Looks good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new hash load balancing method to resty.upstream.socket. This
hash is a CRC32 of the given key modulo the sum of weights of
available hosts. 'Available hosts' are determined before a connection
attempt is made, so that host weights can be taken into account when
deriving the hash. This stands in contrast to the existing round
robin implementation, which walks the entire list of host and then
checks its availability after making a weighted decision.
Hash keys can be provided by an optional param to upstream:connect().
It would make more sense to provide a function to derive the key as
part of defining the pool, but because pools are serialized as JSON,
this is a no-go.
See issue #12 for the initial discussion regarding additional load
balancing schemes.