V1.2.7 && v1.2.8 Helm chart addition #59
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravi100k
force-pushed
the
v1.2.7(use-bind-mount)
branch
from
c24b771 to
a8dfbe6
Compare
ravi100k
changed the title
|
@ravi100k I asked Trond and Luis Pabon to review this Pull Request. And some of the comments that came back was that there wasn't enough contextual information regarding the changes that have been made...and it's quite a large PR to just approve without that context. I'm wondering if we might be able to either ask you to provide more context for this PR and/or could we all get together and have a PR review meeting to just address all of the questions? Thanks... |
added 3 commits
August 20, 2025 22:11
V1.2.7 added node bind mount to reduce api calls. V1.2.7 added helm chart to deploy V1.2.7 added heml package V1.2.7 added heml package V1.2.7 added repo tz file, added readme file
1. Reverted some non usefull changes. Will add up in v1.2.8.
ravi100k
force-pushed
the
v1.2.7(use-bind-mount)
branch
from
88d8546 to
b681528
Compare
ravi100k
changed the title
lpabon
reviewed
Aug 25, 2025
deploy/helm/README.md
Outdated
|
|
||
| 2. **Install the chart into your cluster:** | ||
| ``` | ||
| helm install hscsi hscsi/ --namespace kube-system --create-namespace |
There was a problem hiding this comment.
There should be instructions on how to create and use values.yml from a user point of view
There was a problem hiding this comment.
Update this document as well as added developer .md file for creating new package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.