Allow no optiopns to be provided, tweak arg names for esbuildOptionsFn

hanami · Oct 11, 2023 · 7bf8c9e · 7bf8c9e
1 parent 61be110
commit 7bf8c9e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/dist/hanami-assets.d.ts b/dist/hanami-assets.d.ts
@@ -6,6 +6,6 @@ interface RunOptions {
     argv?: string[];
     esbuildOptionsFn?: EsbuildOptionsFn;
 }
-type EsbuildOptionsFn = (args: Args, options: Partial<BuildOptions>) => Partial<BuildOptions>;
-export declare const run: (options: RunOptions) => Promise<BuildContext | void>;
+type EsbuildOptionsFn = (args: Args, esbuildOptions: Partial<BuildOptions>) => Partial<BuildOptions>;
+export declare const run: (options?: RunOptions) => Promise<BuildContext | void>;
 export {};
diff --git a/dist/hanami-assets.js b/dist/hanami-assets.js
@@ -5,7 +5,7 @@ import esbuild from "esbuild";
 import { parseArgs } from "./args.js";
 import { buildOptions, watchOptions } from "./esbuild.js";
 export const run = async function (options) {
-    const { root = process.cwd(), argv = process.argv, esbuildOptionsFn = null, } = options;
+    const { root = process.cwd(), argv = process.argv, esbuildOptionsFn = null, } = options || {};
     const args = parseArgs(argv);
     // TODO: make nicer
     let esbuildOptions = args.watch ? watchOptions(root, args) : buildOptions(root, args);

diff --git a/src/hanami-assets.ts b/src/hanami-assets.ts
@@ -13,14 +13,14 @@ interface RunOptions {
   esbuildOptionsFn?: EsbuildOptionsFn
 }
 
-type EsbuildOptionsFn = (args: Args, options: Partial<BuildOptions>) => Partial<BuildOptions>;
+type EsbuildOptionsFn = (args: Args, esbuildOptions: Partial<BuildOptions>) => Partial<BuildOptions>;
 
-export const run = async function(options: RunOptions): Promise<BuildContext | void> {
+export const run = async function(options?: RunOptions): Promise<BuildContext | void> {
   const {
     root = process.cwd(),
     argv = process.argv,
     esbuildOptionsFn = null,
-  } = options;
+  } = options || {};
 
   const args = parseArgs(argv);