[POC]: migrate to vitest #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoroth
reviewed
Oct 15, 2023
There was a problem hiding this comment.
You technically don't even need this file, but maybe it still makes sense to keep it around for reference
There was a problem hiding this comment.
I contemplated not adding it, but I think it's nice just to keep it around. I dont need "environment" either, but I think it's nice to keep it around just to be explicit.
jodosha
reviewed
Oct 16, 2023
There was a problem hiding this comment.
@KonnorRogers Thanks for this PR, but...
- It's surprising (no previous discussion), and it doesn't explain why we want to migrate from jest to vitest (TIL).
- Why did you remove
package-lock.jsonin the context of this PR? If that is a change to that you suggest to make, please open a different PR.
Konnor, don't get me wrong, I appreciate you taking care of this, it's just about OSS governance. 🙂
|
@jodosha Probably should've added a [POC] onto this 😭 and provided context.
https://ruby.social/@timriley/111210945213541284
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes: there is a
--threads="false"in the runner. This is because of theprocesss.chdircall.vitest-dev/vitest#566