Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile within single slice only #20

Merged
merged 26 commits into from
Feb 6, 2024
Merged

Compile within single slice only #20

merged 26 commits into from
Feb 6, 2024

Commits on Feb 3, 2024

  1. Path slice path via args and look for assets in single slice only

    Tests aren't fully green yet, but I've made one pass for this new approach.
    timriley committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    a666d2e View commit details
    Browse the repository at this point in the history
  2. Remove publicDir plugin option

    We weren't using this at all
    timriley committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    16e2c9a View commit details
    Browse the repository at this point in the history
  3. Use --target arg to determine output directory

    This will allow our CLI to call this from the outside and provide an appropriate --target for each slice.
    timriley committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    2228a4d View commit details
    Browse the repository at this point in the history
  4. Fix argv format in tests

    timriley committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    1458b9c View commit details
    Browse the repository at this point in the history
  5. Write manifest file inside target dir

    This keeps the assets per slice completely self contained, and will allow us to have abitrarily deep structures of compiled slice asset directories while still retaining clarity.
    timriley committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    8a3294a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6916c34 View commit details
    Browse the repository at this point in the history
  7. Refactor

    timriley committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    d941afd View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    15440ac View commit details
    Browse the repository at this point in the history
  9. Fix SRI handling

    timriley committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    1c811ac View commit details
    Browse the repository at this point in the history
  10. Include fonts in tests

    timriley committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    cc86929 View commit details
    Browse the repository at this point in the history
  11. Remove "full app" scenario

    This is invalid now that we're targeting single app or slice assets.
    timriley committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    fed9b7b View commit details
    Browse the repository at this point in the history
  12. Fix watch test

    timriley committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    3abccdc View commit details
    Browse the repository at this point in the history
  13. Clean up after tests again

    timriley committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    6ba5309 View commit details
    Browse the repository at this point in the history
  14. Prettier

    timriley committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    425f947 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    3ee71a5 View commit details
    Browse the repository at this point in the history
  16. Use extension from compiled asset in manifest keys

    This means that .ts files will have .js extensions when referencing them, as before.
    timriley committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    6512383 View commit details
    Browse the repository at this point in the history
  17. Put CSS, etc. back in the manifest

    Whoops
    timriley committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    246826b View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Fix prettier issue

    timriley committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    a620554 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Rename --target to --dest

    timriley committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    cfb376b View commit details
    Browse the repository at this point in the history
  2. Pass root into the plugin options from the outside

    This means there’s now only one place we need to determine the root: index.ts
    timriley committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    506b532 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    87b28aa View commit details
    Browse the repository at this point in the history
  4. Extract “assets” strings into constants

    These are in two places for now, but at least this makes this special string a little clearer.
    timriley committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    c029f8a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    827d434 View commit details
    Browse the repository at this point in the history
  6. Remove stale comment

    timriley committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    1bd2ecc View commit details
    Browse the repository at this point in the history
  7. Shift regexp up a level

    timriley committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    1ffd9a6 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    aafddf5 View commit details
    Browse the repository at this point in the history