Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the action instance to the request environment #446

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add the action instance to the request environment #446

wants to merge 1 commit into from

Commits on Jun 27, 2024

  1. Add the action instance to the request environment 

    I created a [new topic] on the Hanami Discourse about improving the
AppSignal APM instrumentation.

To group requests, we would like to know what action it took place in.
This information is currently not available in the request environment.

For us, the easiest would be to access the action instance. That gives
us the class information and a way to access the `params_class` to fetch
all the parameters of the request: query params and the body payload.

This change adds the action instance on a new request environment key
`hanami.action_instance`.

[new topic]: https://discourse.hanamirb.org/t/questions-for-improving-the-appsignal-apm-integration-with-hanami-2/989/3

I had to update one test to not fail on the action instance being
returned, which is not important for that spec I think.

Closes hanami#445
    @tombruijn
    tombruijn committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    6a329ea View commit details
    Browse the repository at this point in the history