New version of tilt (2.4.0) broke the build #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![depfu[bot]](https://avatars.githubusercontent.com/in/715?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've tested your project with an updated dependency and the build failed.
This version is either within the version range you specified or you haven't specified a version/range. To be able to test your project with the new version, we've taken the liberty of pinning the version for this branch and pull request.
Unfortunately, we encountered failing tests after pinning. This means that this new version is not compatible with your project and the test failure will potentially also happen on fresh installs.
If you have correctly specified a semantic versioning version range, you should probably also file an issue with the upstream project as they might have released an update that's breaking SemVer rules, which is not cool. (But then again, not all projects explicitly follow SemVer)
We've left the pull request open for you to investigate this issue. Please don't merge it as is, because, again, we've pinned the version of tilt for this test run.
What changed?
✳️ tilt (~> 2.0, >= 2.0.1 → 2.4.0) · Repo · Changelog
Release Notes
2.4.0 (from changelog)
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 15 commits:
Bump version to 2.4.0Add nocov markings around old commonmarker templateAdjust CI gemfile to fix issuesFix ScssTemplate#sass_options when using sass-embeddedMake SassTemplate ignore unsupported options when using sass-embeddedDon't test Maruku in CI on JRuby 9.2Simplify prawn test checking now that checked_describe can take multiple argumentsRemove modification of string literals in testsDeprecate erubis, wikicloth, and maruku templates as they require modifying string literalsMake etanni template work with frozen string literalsUpdate CHANGELOGSupport Commonmarker v1 apiLimit markaby version to < 0.9.1 in CI on Ruby <2.7Limit commonmarker in CI to < 1Add Ruby 3.3 to CI and bump actions/checkout to v4