Add include Dry::Monads[:result] to Rspec blocks #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps `support/rspec.rb` focused on the core RSpec configuration only, and remains consistent with our approach of dedicated spec/support/ files for high-level features.
|
Great pickup, @cllns! I've updated this to generate the setup into Will merge this in now and am very happy to see it going into beta1 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently don't allow people to opt-out of dry-operation on
hanami newso it's safe to assume they'll have dry-monads as a transitive dependency. If they choose to remove it, it'll be clear that they can delete this line without any issues