-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace :crypto.hmac_* with :crypto.mac_* on OTP >= 24 #12
base: master
Are you sure you want to change the base?
Conversation
@handnot2 @zeroasterisk can you merge this PR and publish a new release of this library ? if your plate is full, can you add me as maintainer on both Github and Hex so I could do it ? I like to keep my deps declaration clean ;-) thanks |
Any updates here? |
Sorry, I'm not a maintainer, cannot help. @handnot2 |
Thanks for the reply @zeroasterisk @handnot2 can you please help unblock the situation here ? |
@handnot2 hasn't had any Github activity of any kind recorded for nearly 2½ years, so I think the best option here might be to fork, rename, release, and try to inform downstream dependents of the new dependency name. I'm not in a position to take that on by myself, but I'd be happy to be included as a non-owner maintainer. |
For anyone interested: @LetThereBeDwight has forked this repo, pulled in the changes, and published to hex as sigaws_otp_24. |
Thanks for this @LetThereBeDwight! |
The
:crypto.hmac_*
functions are no longer present in OTP 24. They've been replaced by:crypto.mac_*
functions with almost identical functionality but a slightly different call signature for theinit
function. This PR includes a compile-time conditional that chooses the right crypto functions based on the OTP version.