-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update typescript, typedoc, vuepress & eslint #1258
Conversation
Performance comparison of head (1b34854) vs base (104ce4c)
|
It's OK. Neither |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as desired. Just one minor remark.
.config/webpack/languages.js
Outdated
const WebpackOnBuildPlugin = require('on-build-webpack'); | ||
const fs = require('fs'); | ||
const fsExtra = require('fs-extra'); | ||
require('string-replace-loader'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move it above declaring variables?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out this require statement is not needed here. I removed it.
Codecov Report
@@ Coverage Diff @@
## develop #1258 +/- ##
========================================
Coverage 97.19% 97.19%
========================================
Files 166 166
Lines 14238 14238
Branches 2965 2965
========================================
Hits 13838 13838
Misses 400 400
|
Context
I reduced number of critical vulnerabilities from 7 to 2. To fix the rest we need to update:
Which require a lot of effort. Draft PR: #1262
How did you test your changes?
Types of changes
Related issues:
Fixes #1239
Checklist: