Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5팀 박소미] [Chapter 2-1] 클린코드와 리팩토링 #39

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
c76d6fe
chore: 프로젝트 기본 설정
confidential-nt Jan 7, 2025
a1e4a7c
test: 테스트 수정
confidential-nt Jan 7, 2025
0f99b33
chore: eslint 설정
confidential-nt Jan 8, 2025
80fcccc
refactor: ui 관련 코드 컴포넌트로 분리
confidential-nt Jan 8, 2025
bf5b1a8
refactor: var 제거 및 변수 이름 수정
confidential-nt Jan 8, 2025
bad3a34
refactor: 상품 목록 리스트를 다른 파일로 분리하고 freeze
confidential-nt Jan 8, 2025
2c9e83c
refactor: 콜백 함수는 화살표 함수로 수정
confidential-nt Jan 8, 2025
01b6280
refactor: 세일 코드 분리
confidential-nt Jan 8, 2025
9c3cd6f
refactor: 장바구니에 들어간 아이템 정보와 ui 분리
confidential-nt Jan 8, 2025
aa2a913
refactor: cart, cart item을 클래스로 캡슐화
confidential-nt Jan 9, 2025
f0ad9ef
refactor: BonusPoints, DiscountRate ui 로직 캡슐화
confidential-nt Jan 9, 2025
7001385
refactor: 재고 정보 class로 캡슐화
confidential-nt Jan 9, 2025
7e3fc41
refactor: ui 표시 및 ui 관련 로직을 캡슐화
confidential-nt Jan 9, 2025
fcb6266
refactor: 이벤트 리스너에서 함수 추출
confidential-nt Jan 9, 2025
f8fc25a
refactor: select 내부 옵션 업데이트 하는 로직 캡슐화
confidential-nt Jan 9, 2025
c6dbe5c
chore: main.original.js에 eslint-disable 적용
confidential-nt Jan 9, 2025
170f0ad
refactor: 전역 변수 제거
confidential-nt Jan 9, 2025
6e3c7a7
fix: import 경로 수정
confidential-nt Jan 9, 2025
0ec000c
test: 임시 테스트 파일
confidential-nt Jan 9, 2025
d196520
refactor: summary 관련 로직 캡슐화 및 함수 형식 통일
confidential-nt Jan 10, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .prettierrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"tabWidth": 2,
"semi": true,
"printWidth": 120,
"plugins": ["@trivago/prettier-plugin-sort-imports"]
}
15 changes: 15 additions & 0 deletions eslint.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import pluginJs from "@eslint/js";
import globals from "globals";

/** @type {import('eslint').Linter.Config[]} */
export default [
{ languageOptions: { globals: globals.browser } },
pluginJs.configs.recommended,
{
rules: {
"no-var": "error",
"no-use-before-define": ["error", { functions: false, classes: false, variables: true }],
"no-undef": "error",
},
},
];
4 changes: 4 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,13 @@
"test:ui": "vitest --ui"
},
"devDependencies": {
"@eslint/js": "^9.17.0",
"@testing-library/jest-dom": "^6.5.0",
"@testing-library/user-event": "^14.5.2",
"@trivago/prettier-plugin-sort-imports": "^5.2.1",
"@vitest/ui": "^2.1.1",
"eslint": "^9.17.0",
"globals": "^15.14.0",
"jsdom": "^25.0.0",
"vite": "^5.1.0",
"vitest": "^2.1.1"
Expand Down
Loading
Loading