Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add state to name debug function #364

Open
wants to merge 2 commits into
base: tls13-prototype
Choose a base branch
from

Conversation

yuhaoth
Copy link
Collaborator

@yuhaoth yuhaoth commented Aug 16, 2021

Add debug functions to dump state machine string.
That's to help debug

Change-Id: I015ae35a141a8b99352f5b90218fe919d7bbdc55
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
Change-Id: I6de197161d012960c391503db3e26db9b1342ff1
CustomizedGitHooks: yes
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
@@ -308,4 +308,7 @@ void mbedtls_debug_printf_ecdh( const mbedtls_ssl_context *ssl, int level,
}
#endif

const char * mbedtls_debug_get_state_string( mbedtls_ssl_states stat);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format: add a space after stat.

@@ -419,4 +419,53 @@ void mbedtls_debug_printf_ecdh( const mbedtls_ssl_context *ssl, int level,
}
#endif /* MBEDTLS_ECDH_C */

const char * mbedtls_debug_get_state_string( mbedtls_ssl_states stat)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Add space.

@@ -419,4 +419,53 @@ void mbedtls_debug_printf_ecdh( const mbedtls_ssl_context *ssl, int level,
}
#endif /* MBEDTLS_ECDH_C */

const char * mbedtls_debug_get_state_string( mbedtls_ssl_states stat)
{
static const char * stat_str[]={
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm, do we always add a space after = ?

Copy link

@zhihan zhihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants