Set call back to delegate entire certificate validation process #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Set call back, `f_verify_callback`, to delegate the entire certificate validation process to application. The application has additional validation logic which is not supported in default mbedtls implementation, such as cert pinning. It may also delegate some validation process to OS. Test Plan: Build and make test Reviewers: hanno.becker@arm.com,hannes.tschofenig@arm.com,junqi.wang@live.com,zhi.han@gmail.com Subscribers: Tasks: Tags:
This comment has been minimized.
This comment has been minimized.
hanno-becker
added
API extension
enhancement
Needs design discussion
needs work
hanno-becker
requested changes
Jan 4, 2021
There was a problem hiding this comment.
@lhuang04 This sounds like a feature extension to Mbed TLS that needs discussion independently of the context of the TLS 1.3 prototype. As such, it needs more information on motivation and design rationale -- if not here, it will certainly be necessary when trying to upstream to Mbed TLS.
Could you describe in more detail which problem you're trying to solve? In particular, I'd like to understand if/why not the existing verification callback mechanism in mbedtls_x509_crt_verify() is insufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Set call back,
f_verify_callback, to delegate the entire certificatevalidation process to application.
The application has additional validation logic which is not supported
in default mbedtls implementation, such as cert pinning. It may also
delegate some validation process to OS.
Test Plan:
Build and make test
Reviewers:
hanno.becker@arm.com,hannes.tschofenig@arm.com,junqi.wang@live.com,zhi.han@gmail.com
Subscribers:
Tasks:
Tags: