Technical: Fully move DungeonAPI.dungeonFloor to enum #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qtlunya
suggested changes
May 22, 2024
src/main/java/at/hannibal2/skyhanni/features/dungeon/DungeonShadowAssassinNotification.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/discordrpc/DiscordLocationKey.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/discordrpc/DiscordStatus.kt
Outdated
Show resolved
Hide resolved
qtlunya
suggested changes
May 22, 2024
Comment on lines
110
to
117
| DungeonFloor.E -> "The Watcher" | ||
| DungeonFloor.F1, DungeonFloor.M1 -> "Bonzo" | ||
| DungeonFloor.F2, DungeonFloor.M2 -> "Scarf" | ||
| DungeonFloor.F3, DungeonFloor.M3 -> "The Professor" | ||
| DungeonFloor.F4, DungeonFloor.M4 -> "Thorn" | ||
| DungeonFloor.F5, DungeonFloor.M5 -> "Livid" | ||
| DungeonFloor.F6, DungeonFloor.M6 -> "Sadan" | ||
| DungeonFloor.F7, DungeonFloor.M7 -> "Maxor" |
There was a problem hiding this comment.
Suggested change
| DungeonFloor.E -> "The Watcher" | |
| DungeonFloor.F1, DungeonFloor.M1 -> "Bonzo" | |
| DungeonFloor.F2, DungeonFloor.M2 -> "Scarf" | |
| DungeonFloor.F3, DungeonFloor.M3 -> "The Professor" | |
| DungeonFloor.F4, DungeonFloor.M4 -> "Thorn" | |
| DungeonFloor.F5, DungeonFloor.M5 -> "Livid" | |
| DungeonFloor.F6, DungeonFloor.M6 -> "Sadan" | |
| DungeonFloor.F7, DungeonFloor.M7 -> "Maxor" | |
| DungeonFloor.F7, DungeonFloor.M7 -> "Maxor" | |
| else -> floor.bossName |
There was a problem hiding this comment.
i'm confused about this one
There was a problem hiding this comment.
Just simplifying the code. It's different for F7/M7 because it checks for the first boss you fight (Maxor) instead of the final boss (Necron).
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
…as-enum # Conflicts: # src/main/java/at/hannibal2/skyhanni/features/misc/ParticleHider.kt
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/features/dungeon/DungeonAPI.kt
|
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
What
Describe what this pull request does, including technical details, screenshots, links to discord, etc.
Images
Changelog New Features
Changelog Improvements
Changelog Fixes
Changelog Technical Details
Changelog Removed Features