Improvement: Dungeon Features Cleanup #2108
Open
+148
−160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
…eatures # Conflicts: # src/main/java/at/hannibal2/skyhanni/data/mob/MobFilter.kt
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
|
Conflicts have been resolved! 🎉 |
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
updated config version
…tion-migration/dungeon-features # Conflicts: # src/main/java/at/hannibal2/skyhanni/features/dungeon/DungeonHighlightClickedBlocks.kt
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
…eatures # Conflicts: # src/main/java/at/hannibal2/skyhanni/config/ConfigUpdaterMigrator.kt # src/main/java/at/hannibal2/skyhanni/config/features/dungeon/DungeonConfig.java # src/main/java/at/hannibal2/skyhanni/features/dungeon/DungeonHighlightClickedBlocks.kt # src/main/java/at/hannibal2/skyhanni/utils/EntityUtils.kt
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
…eatures # Conflicts: # src/main/java/at/hannibal2/skyhanni/config/ConfigUpdaterMigrator.kt # src/main/java/at/hannibal2/skyhanni/utils/BlockUtils.kt
|
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
Signed-off-by: ItsEmpa <itsempa@users.noreply.github.com>
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/data/mob/Mob.kt # src/main/java/at/hannibal2/skyhanni/features/dungeon/DungeonLividFinder.kt # src/main/java/at/hannibal2/skyhanni/features/dungeon/HighlightDungeonDeathmite.kt # src/main/java/at/hannibal2/skyhanni/features/dungeon/TerracottaPhase.kt # src/main/java/at/hannibal2/skyhanni/utils/RenderUtils.kt
|
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
jani270
added
the
Soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
What
General cleanup of basically all dungeon features. moved some patterns to be repopatterns, used mob detection when it can be used, etc.
Theres also some cleanup in block utils, deprecating armor stand related functions in entity utils (in favor of using mob detection), and added an exactBoundingBox method for entities.
Changelog Improvements
Changelog Technical Details