Fix: Double Powder Detection #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannibal002
requested changes
Jun 30, 2024
There was a problem hiding this comment.
the event widget is default disabled. this means we need to tell the user to enable the widget in order to fully use the powder tracker.
also this gets overwritten by other events, e.g. hoppity event.
im not sure if replacing the original logic is a good idea. maybe keep the BossbarData logic as a workaround until we can confirm the tab widget logic works 100%
hannibal002
requested changes
Jul 6, 2024
src/main/java/at/hannibal2/skyhanni/features/mining/powdertracker/PowderTracker.kt
Show resolved
Hide resolved
hannibal002
requested changes
Jul 15, 2024
src/main/java/at/hannibal2/skyhanni/features/mining/powdertracker/PowderTracker.kt
Outdated
Show resolved
Hide resolved
hannibal002
changed the title
hannibal002
changed the title
hannibal002
added
the
Soon
hannibal002
approved these changes
Jul 26, 2024
github-actions
bot
removed
Soon
Nealkitt
pushed a commit
to Nealkitt/SkyHanni
that referenced
this pull request
Sep 8, 2024
Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix detection of 2x Powder event in Powder Tracker
Changelog Fixes