Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Stackoverflow for getPrice #2199

Merged

Conversation

Thunderblade73
Copy link
Contributor

@Thunderblade73 Thunderblade73 commented Jul 6, 2024

What

Fixes infite recursion for looping recipes. Eg: A is made out of B and B is made out of C and C can be made with A. Makeing a closed loop where it never finishes.

It is fixed in that it keeps track if the recipe was already called in the stack. Meaning it will skip it (since it will lead to no end).

Changelog Fixes

  • Fix random Stack Overflow Errors. - Thunderblade73

@jani270 jani270 requested a review from hannibal002 July 6, 2024 20:17
@jani270 jani270 added the Bug Fix Bug fixes label Jul 6, 2024
@hannibal002 hannibal002 added this to the Version 0.26 milestone Jul 6, 2024
@Thunderblade73 Thunderblade73 changed the title Fix: Stackoverflow for getPrice Fi: Stackoverflow for getPrice Jul 6, 2024
@Thunderblade73 Thunderblade73 changed the title Fi: Stackoverflow for getPrice Fix: Stackoverflow for getPrice Jul 6, 2024
@Thunderblade73 Thunderblade73 changed the title Fix: Stackoverflow for getPrice Fi: Stackoverflow for getPrice Jul 6, 2024
@Thunderblade73 Thunderblade73 changed the title Fi: Stackoverflow for getPrice Fix: Stackoverflow for getPrice Jul 6, 2024
@Thunderblade73 Thunderblade73 changed the title Fix: Stackoverflow for getPrice Fi: Stackoverflow for getPrice Jul 6, 2024
@Thunderblade73 Thunderblade73 changed the title Fi: Stackoverflow for getPrice Fix: Stackoverflow for getPrice Jul 6, 2024
@Thunderblade73 Thunderblade73 changed the title Fix: Stackoverflow for getPrice Fi: Stackoverflow for getPrice Jul 6, 2024
@Thunderblade73 Thunderblade73 changed the title Fi: Stackoverflow for getPrice Fix: Stackoverflow for getPrice Jul 6, 2024
@Thunderblade73 Thunderblade73 changed the title Fix: Stackoverflow for getPrice Fi: Stackoverflow for getPrice Jul 6, 2024
@Thunderblade73 Thunderblade73 changed the title Fi: Stackoverflow for getPrice Fix: Stackoverflow for getPrice Jul 6, 2024
@hannibal002 hannibal002 merged commit bcbdf74 into hannibal002:beta Jul 7, 2024
4 of 14 checks passed
@github-actions github-actions bot removed the Bug Fix Bug fixes label Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants