Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Stray Rabbit Tracker #2210

Merged
merged 21 commits into from
Jul 30, 2024
Merged

Feature: Stray Rabbit Tracker #2210

merged 21 commits into from
Jul 30, 2024

Conversation

DavidArthurCole
Copy link
Contributor

@DavidArthurCole DavidArthurCole commented Jul 10, 2024 •
edited by hannibal002
Loading

What

Add a tracker for stray rabbits, and counting the extra production gained from them.

image

Changelog New Features

  • Added a tracker for stray rabbits caught in the Chocolate Factory. - Daveed

@DavidArthurCole
Copy link
Contributor Author

image

Progress continues. Still need a couple more patterns before I'm done.

@DavidArthurCole DavidArthurCole marked this pull request as ready for review July 16, 2024 02:54
@DavidArthurCole
Copy link
Contributor Author

All patterns are done, this is ready to go.

@hannibal002
Copy link
Owner

Cool idea and good looking code!

Please use SkyHanniTracker. See VerminTracker.kt for a simple implementation.
A more detailed review will follow later.

@hannibal002 hannibal002 added this to the Version 0.26 milestone Jul 16, 2024
@DavidArthurCole
Copy link
Contributor Author

Cool idea and good looking code!

Please use SkyHanniTracker. See VerminTracker.kt for a simple implementation. A more detailed review will follow later.

Unfortunately I won't be able to re-verify all functionality until the next hoppity's event, but looks like the re-implementation using SkyHanniTracker is functional.

image

hannibal002
hannibal002 requested changes Jul 16, 2024
View reviewed changes
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks fine, good job!
One small thing I have noticed:
image
We want to modify both display modes at the same time. IDK anymore why the vermin tracker handles this differently than the other trackers.

@hannibal002
Copy link
Owner

We can extract this behavior the same way we do for incrementRarity: (idk the correct function name here)
image

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jul 17, 2024
hannibal002
hannibal002 requested changes Jul 28, 2024
View reviewed changes
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine in game

...va/at/hannibal2/skyhanni/features/inventory/chocolatefactory/ChocolateFactoryStrayTracker.kt Outdated Show resolved Hide resolved
...va/at/hannibal2/skyhanni/features/inventory/chocolatefactory/ChocolateFactoryStrayTracker.kt Outdated Show resolved Hide resolved
@hannibal002 hannibal002 merged commit 47c0590 into hannibal002:beta Jul 30, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Jul 30, 2024
@DavidArthurCole DavidArthurCole deleted the StrayTracker branch July 30, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannibal002 hannibal002 Awaiting requested review from hannibal002

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.26
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidArthurCole @hannibal002