Feature: Accessory MP as stack size #2243

minhperry · 2024-07-20T22:44:37Z

What

https://discord.com/channels/997079228510117908/1263951633059156009

Images

Changelog New Features

Added Accessory magical power display as stack size. - minhperry
- Only works inside the Accessory Bag and Auction House.

hannibal002

Thanks for this pr! the code looks good overall, still needs some polishing.

src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt

src/main/java/at/hannibal2/skyhanni/config/features/misc/MPDisplayConfig.java

src/main/java/at/hannibal2/skyhanni/config/features/misc/MiscConfig.java

src/main/java/at/hannibal2/skyhanni/config/features/misc/MPDisplayConfig.java

src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt

minhperry · 2024-07-22T22:14:59Z

adding support for abicases for now

minhperry · 2024-07-22T23:39:03Z

for some reasons the "Auctions: *" regex would just never pass despite passing IJ tester

minhperry · 2024-07-24T12:23:57Z

Is this intended it just spams my email with this

Thunderblade73

Sorry, I late to this. But what the isAccessory function does should already be done by the itemCategory code. If it isn't for some wierd reason / edge case, please let me know and I will fix it.

src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt

Thunderblade73

Code structure is good. But you missed some stuff that is mostly unqiue to our repo (eg: pattern for mostly everything). I also added some formatting stuff that makes the code look better.

src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt

src/main/java/at/hannibal2/skyhanni/config/features/inventory/MagicalPowerConfig.java

src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt

# Conflicts: # src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt

github-actions · 2024-08-26T00:44:52Z

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

github-actions · 2024-08-26T12:15:06Z

Conflicts have been resolved! 🎉

Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>

minhperry added 4 commits July 21, 2024 00:12

feat: mp as stack size

706eefb

fix: fix edge cases

9ba8a35

refactor: rename and restructure variables

fe75cb8

refactor: spacing

7f71190

hannibal002 requested changes Jul 21, 2024

View reviewed changes

hannibal002 added this to the Version 0.26 milestone Jul 21, 2024

hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jul 21, 2024

qtlunya suggested changes Jul 21, 2024

View reviewed changes

src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt Outdated Show resolved Hide resolved

src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt Outdated Show resolved Hide resolved

minhperry added 2 commits July 21, 2024 13:30

test: add regex tests

a05c6d8

refactor: move and rename class to correct place

491fff0

j10a1n15 suggested changes Jul 21, 2024

View reviewed changes

src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt Outdated Show resolved Hide resolved

minhperry added 2 commits July 21, 2024 14:34

fix: resolving conversations pt 1

c7da6c6

fix: resolving conversations pt final / re-add isAcc

d53cc47

minhperry requested a review from hannibal002 July 21, 2024 15:34

minhperry added 3 commits July 21, 2024 17:41

clean: cleanup spaces

e954d31

fix: map -> fun

589e7d8

refactor: change 4 convention

7c4d267

minhperry marked this pull request as draft July 22, 2024 22:14

feat: add edge case abicases

7e44efa

fix: pattern for AH

5e0f150

minhperry marked this pull request as ready for review July 24, 2024 11:34

Merge branch 'refs/heads/beta' into fork/minhperry/mp-stack-size

bf467aa

Thunderblade73 suggested changes Jul 24, 2024

View reviewed changes

src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt Outdated Show resolved Hide resolved

minhperry added 3 commits July 25, 2024 01:15

fix: use built-in rarity detection

3587ce9

Merge remote-tracking branch 'origin/mp-stack-size' into mp-stack-size

1e4b275

clean: cleanup debug code

b20f956

Thunderblade73 suggested changes Jul 25, 2024

View reviewed changes

hannibal002 modified the milestones: Version 0.26, Version 0.27 Jul 31, 2024

hannibal002 removed the Soon This Pull Request will be merged within the next couple of betas label Jul 31, 2024

hannibal002 modified the milestones: Version 0.27, Version 0.28 Aug 13, 2024

minhperry and others added 7 commits August 14, 2024 15:47

Merge branch 'hannibal002:beta' into mp-stack-size

004b5d6

fix: resolving Thunder's conversations pt 2

ffee790

fix: resolving Hanni's conv pt 1

e832a22

Merge remote-tracking branch 'origin/mp-stack-size' into mp-stack-size

2e53def

# Conflicts: # src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt

refactor: regex tests

8cd35dd

fix: default to 0 contact

5e06829

fix: nullability 2

561adeb

hannibal002 modified the milestones: Version 0.28, Version 0.27 Aug 21, 2024

hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Aug 21, 2024

fix: nullability 2.5

511fbe4

minhperry requested a review from hannibal002 August 24, 2024 02:48

github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Aug 26, 2024

Merge branch 'beta' into mp-stack-size

3cb2167

github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Aug 26, 2024

minhperry and others added 4 commits August 26, 2024 14:15

Merge branch 'hannibal002:beta' into mp-stack-size

ce36e85

Merge branch 'refs/heads/beta' into fork/minhperry/mp-stack-size

7d2496a

fixed regex tests not working

a3b9ec3

code cleanup

603583e

hannibal002 approved these changes Sep 7, 2024

View reviewed changes

hannibal002 merged commit 4663ebc into hannibal002:beta Sep 7, 2024
4 checks passed

github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Sep 7, 2024

MTOnline69 pushed a commit to MTOnline69/SkyHanni that referenced this pull request Sep 11, 2024

Feature: Accessory MP as stack size (hannibal002#2243)

9931d83

Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Accessory MP as stack size #2243

Feature: Accessory MP as stack size #2243

minhperry commented Jul 20, 2024 •

edited by hannibal002

Loading

hannibal002 left a comment

minhperry commented Jul 22, 2024

minhperry commented Jul 22, 2024

minhperry commented Jul 24, 2024

Thunderblade73 left a comment

Thunderblade73 left a comment

github-actions bot commented Aug 26, 2024

github-actions bot commented Aug 26, 2024

Feature: Accessory MP as stack size #2243

Feature: Accessory MP as stack size #2243

Conversation

minhperry commented Jul 20, 2024 • edited by hannibal002 Loading

What

Changelog New Features

hannibal002 left a comment

Choose a reason for hiding this comment

minhperry commented Jul 22, 2024

minhperry commented Jul 22, 2024

minhperry commented Jul 24, 2024

Thunderblade73 left a comment

Choose a reason for hiding this comment

Thunderblade73 left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 26, 2024

github-actions bot commented Aug 26, 2024

minhperry commented Jul 20, 2024 •

edited by hannibal002

Loading