Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Crystal Nucleus Tracker, Profit-Per, and Filter #2285

Open
wants to merge 34 commits into
base: beta
Choose a base branch
from
Open

Feature: Crystal Nucleus Tracker, Profit-Per, and Filter #2285

wants to merge 34 commits into from
+700 −46

Conversation

DavidArthurCole
Copy link
Contributor

@DavidArthurCole DavidArthurCole commented Aug 1, 2024 •
edited by hannibal002
Loading

What

https://discord.com/channels/997079228510117908/1194240426375401552
Adds Profit Per & Tracker for Crystal Nucleus Runs, based on the new chat messages from SB Alpha.
Adds a toggleable and configurable chat filter for the Crystal Nucleus.

Images

Per-Profit Message:
image

Tracker:
image

Chat Filters:

image

image

image

image

image

image

image

Changelog New Features

  • Added Profit-Per for Crystal Nucleus runs. - Daveed
  • Added profit tracker for Crystal Nucleus runs. - Daveed
  • Added a chat filter for Crystal Nucleus runs. - Daveed

Changelog Technical Details

  • Added CrystalNucleusLootEvent, which will fire with loot info on a Nucleus run being completed. - Daveed

@DavidArthurCole DavidArthurCole changed the title Feature: Crystal Nucleus Tracker & Profit-Per Feature: Crystal Nucleus Tracker, Profit-Per, and Filter Aug 2, 2024
@DavidArthurCole DavidArthurCole marked this pull request as ready for review August 2, 2024 20:32
@DavidArthurCole
Copy link
Contributor Author

This is ready for review, and could be merged as soon as that's done, however the per-profit and tracker won't function until the new Crystal Nucleus messages (in Alpha atm) make it to SB.

@DavidArthurCole
Copy link
Contributor Author

The new nuc run messages are in SB, so this is ready to go

@hannibal002 hannibal002 added this to the Version 0.27 milestone Aug 8, 2024
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Aug 26, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Aug 26, 2024
@hannibal002 hannibal002 modified the milestones: Version 0.27, Version 0.28 Sep 7, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Sep 26, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Sep 30, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot added Merge Conflicts There are open merge conflicts with the beta branch. and removed Merge Conflicts There are open merge conflicts with the beta branch. labels Sep 30, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Sep 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 3, 2024
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Conflicts have been resolved! 🎉

@CalMWolfs CalMWolfs self-requested a review October 8, 2024 11:04
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Oct 12, 2024
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 13, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalMWolfs CalMWolfs Awaiting requested review from CalMWolfs

@ItsEmpa ItsEmpa Awaiting requested review from ItsEmpa

Assignees
No one assigned
Labels
Soon This Pull Request will be merged within the next couple of betas
Projects
None yet
Milestone
Version 0.28
Development

Successfully merging this pull request may close these issues.
4 participants
@DavidArthurCole @ItsEmpa @hannibal002 @CalMWolfs