Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Create and use primitive recipe and ingredient #2460

Merged

Conversation

CalMWolfs
Copy link
Collaborator

@CalMWolfs CalMWolfs commented Sep 4, 2024

What

One of the last steps in being able to make a skyhanni version that can be run without neu is dealing with the item data that neu has (recipes and ingredients) this pr converts those data types into skyhanni specific types that only have the needed functions for skyhanni

Changelog Technical Details

  • Created and used primitive recipe and ingredient classes. - CalMWolfs
    • These are added as a layer between SkyHanni and NEU so that we are not reliant on NEU functions.

@hannibal002 hannibal002 added this to the Version 0.27 milestone Sep 7, 2024
@jani270 jani270 added the Soon This Pull Request will be merged within the next couple of betas label Sep 9, 2024
@hannibal002 hannibal002 merged commit b0735ff into hannibal002:beta Sep 23, 2024
4 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Sep 23, 2024
@CalMWolfs CalMWolfs deleted the primative-recipes-and-ingredients branch September 23, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants