Fix: Mod Compatilibty issues in Party Finder #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MTOnline69
pushed a commit
to MTOnline69/SkyHanni
that referenced
this pull request
Sep 11, 2024
Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In Dungeon's Party Finder, SkyHanni redraws the item tooltip even when the two features that can affect the tooltip are disabled, causing other mods to break.
This PR now checks if one of those features is enabled, and only changes the tooltip there.
Ideally, the other affected mods would also change their priority or detection to add direct support for SkyHanni. Or maybe we do this?
Changelog Fixes