Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Re-Enable Style Checking Workflow #2491

Closed

Conversation

DavidArthurCole
Copy link
Contributor

What

Re-enable the check-style workflow, as it's back to working correctly.
Tested runner here.

exclude_from_changelog

@DavidArthurCole
Copy link
Contributor Author

And of course it doesn't work on the PR into the repo 🙃
More to come - as I've been digging at this...

@DavidArthurCole
Copy link
Contributor Author

Oh. It didn't fail to work.
It correctly identified a whole shitload of bad formatting since it's been disabled.

Don't know what we wanna do about that ...

@hannibal002
Copy link
Owner

this file is 404 for me

Could not GET 'https://maven.deftu.xyz/releases/dev/deftu/preprocessor/0.6.1/preprocessor-0.6.1.jar'.

@j10a1n15
Copy link
Contributor

@hannibal002 hannibal002 added this to the Version 0.28 milestone Sep 10, 2024
@hannibal002
Copy link
Owner

Don't know what we wanna do about that ...

Can we make it only check changed files?
If not, we should disable the most commonly flagged rules, and fix the remaining bugs immediately. Then over time, re-enable the rules again.

@DavidArthurCole
Copy link
Contributor Author

Closing this in favor of #2547

@DavidArthurCole DavidArthurCole deleted the StyleCheckBack branch September 20, 2024 21:22
@CalMWolfs CalMWolfs removed this from the Version 0.28 milestone Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants