Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: AreaChangeEvent and Islands in HandleEvent #2535

Merged
merged 5 commits into from
Sep 21, 2024

Conversation

ItsEmpa
Copy link
Contributor

@ItsEmpa ItsEmpa commented Sep 18, 2024

What

Adds AreaChangeEvent and uses it in MiningAPI, and changes some stuff in LocationFixData to use a map.
Also reverts the changes for the onlyOnIsland argument in the HandleEvent annotation in #2502 , and adds a separate argument to use when using multiple IslandType.
For checking a single IslandType, use onlyOnIsland, and for multiple use onlyOnIslands.

Changelog Technical Details

  • Added AreaChangeEvent. - Empa
  • Updated HandleEvent to allow onlyOnIsland usage for a single island without brackets. - Empa

…vent be able to take single or multiple island types without having to use brackets

Signed-off-by: ItsEmpa <itsempa@users.noreply.github.com>
Signed-off-by: ItsEmpa <itsempa@users.noreply.github.com>
… after skyblock area

Signed-off-by: ItsEmpa <itsempa@users.noreply.github.com>
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@hannibal002 hannibal002 added this to the Version 0.27 milestone Sep 20, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Sep 20, 2024
@hannibal002 hannibal002 merged commit 208fc04 into hannibal002:beta Sep 21, 2024
4 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Sep 21, 2024
@ItsEmpa ItsEmpa deleted the backend/location-improvements branch October 12, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants