Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Strays Wrongly Counting as Unique #2627

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

DavidArthurCole
Copy link
Contributor

What

duplicate was not being set at all during the stray section of the Hoppity API. This fixes that.

Changelog Fixes

  • Fixed Fish the Rabbit and El Dorado incorrectly counting as unique rabbits during Hoppity's Hunt. - Daveed

@github-actions github-actions bot added the Bug Fix Bug fixes label Oct 1, 2024
@qtlunya
Copy link
Contributor

qtlunya commented Oct 1, 2024

Shouldn't these be a RepoPattern?

@hannibal002 hannibal002 added this to the Version 0.27 milestone Oct 1, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Oct 1, 2024
@hannibal002 hannibal002 merged commit 22dfa1e into hannibal002:beta Oct 1, 2024
4 checks passed
@github-actions github-actions bot removed Soon This Pull Request will be merged within the next couple of betas Bug Fix Bug fixes labels Oct 1, 2024
@DavidArthurCole DavidArthurCole deleted the FishDupe branch October 1, 2024 18:00
Tryp0xd pushed a commit to Tryp0xd/SkyHanni that referenced this pull request Oct 3, 2024
* Version 0.27 Beta 13

* Feature: West Village/Dreadfarm/Living Cave features (hannibal002#2616)

Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>

* Fix: Jasper Gemstones not in Powder Mining Filter (hannibal002#2618)

* changed todo

* added parameter `/shcopylocation pathfind`

* Fix a massive bug (hannibal002#2626)

* Fix: Typos in readme (hannibal002#2629)

* Fix: Custom Scoreboard Carnival (hannibal002#2631)

* formatting

* Fix: Add more Pablo patterns (hannibal002#2636)

* Fix: Minister in Calendar Color Reset (hannibal002#2632)

* Fix: Strays Wrongly Counting as Unique (hannibal002#2627)

* Fix: Item trackers saying removed item name from item name (hannibal002#2620)

* fix time format showing empty string for sub 1s

* fixed composter data collection

* Improvement: Add ignored crops for lane features (hannibal002#2622)

* Improvement: Change "efficient miner" to "spread" in mineshaft pity breakdown (hannibal002#2633)

* Backend: Rename keystore file to specify it is for skyhanni (hannibal002#2619)

* Fix: Superpair Data (hannibal002#2566)

Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>
Co-authored-by: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com>

* Improvement: Added cooldown to Carnival NPC click (hannibal002#2628)

* Automatically stating pathfind after clicking the hypixel reminder ch… (hannibal002#2635)

Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>

* Improvement: Pathfind Rendering (hannibal002#2634)

Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>

* Backend: Alert Clock Offsets (hannibal002#2623)

Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>
Co-authored-by: CalMWolfs <cwolfson58@gmail.com>

* fixed typo in broodmother message

* fixed errors when path is zero

* Version 0.27 Beta 14

* Improvement: Slight Touch up for Hoppity Event Summary (hannibal002#2638)

* code cleanup

* Fix: Highlight in Bazaar (hannibal002#2640)

Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>

* Fix: Flare expire warning (hannibal002#2643)

Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>

* Fix: Ender node tracker (hannibal002#2644)

Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>

* Fix: Powder Tracker not tracking items (hannibal002#2645)

* Fix: Preconditions to debug commands (hannibal002#2641)

Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>
Co-authored-by: CalMWolfs <cwolfson58@gmail.com>

* Fix: Dummies and Damage Indicator (hannibal002#2646)

Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>

* fixed wrong feature toggle

* Improvement: Superpair Experimentation data always visible (hannibal002#2647)

Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>
Co-authored-by: CalMWolfs <cwolfson58@gmail.com>

* Backend: Detekt Fixes Part 5 (hannibal002#2617)

---------

Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>
Co-authored-by: MTOnline69 <97001154+MTOnline69@users.noreply.github.com>
Co-authored-by: David Cole <40234707+DavidArthurCole@users.noreply.github.com>
Co-authored-by: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com>
Co-authored-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Co-authored-by: Luna <me@lunya.dev>
Co-authored-by: martimavocado <39881008+martimavocado@users.noreply.github.com>
Co-authored-by: ILike2WatchMemes <ilike2watchmemes@gmail.com>
Co-authored-by: minhperry <46137516+minhperry@users.noreply.github.com>
Co-authored-by: hannibal2 <24389977+hannibal002@users.noreply.github.com>
Co-authored-by: CalMWolfs <cwolfson58@gmail.com>
Co-authored-by: HiZe <super@hize.be>
Co-authored-by: ItsEmpa <itsempa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants