Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Stash Warning Compact #2639

Merged
merged 14 commits into from
Oct 13, 2024
Merged

Feature: Stash Warning Compact #2639

merged 14 commits into from
Oct 13, 2024

Conversation

DavidArthurCole
Copy link
Contributor

@DavidArthurCole DavidArthurCole commented Oct 2, 2024 •
edited by hannibal002
Loading

What

Added a compactor for the stash warning messages.

Changelog New Features

  • Added chat compacting for 'items in stash' warnings. - Daveed

@DavidArthurCole
Copy link
Contributor Author

Fire, this already got done in a similar way in #2013, which has had conflicts since June. So, I guess this is a continuation PR, now?

@hannibal002
Copy link
Owner

Fire, this already got done in a similar way in #2013, which has had conflicts since June. So, I guess this is a continuation PR, now?

agreed. will close the other pr

@hannibal002 hannibal002 mentioned this pull request Oct 2, 2024
Closed
2 tasks
@hannibal002 hannibal002 added this to the Version 0.28 milestone Oct 2, 2024
CalMWolfs
CalMWolfs requested changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things I saw
would also be good to include an image of the option both on compact mode and the default hypixel message but these arent necessary

src/main/java/at/hannibal2/skyhanni/features/chat/StashCompact.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/chat/ChatConfig.java Outdated Show resolved Hide resolved
@jani270 jani270 added the Soon This Pull Request will be merged within the next couple of betas label Oct 11, 2024
hannibal002
hannibal002 requested changes Oct 13, 2024
View reviewed changes
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format doesn't look like SkyHanni to me. The colors are "off". Please use yellow/white/red ish colors
image

src/main/java/at/hannibal2/skyhanni/features/chat/StashCompact.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/chat/StashCompact.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/chat/StashCompact.kt Outdated Show resolved Hide resolved
@hannibal002 hannibal002 merged commit 5fd54d5 into hannibal002:beta Oct 13, 2024
4 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Oct 13, 2024
@DavidArthurCole DavidArthurCole deleted the StashCompact branch October 13, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannibal002 hannibal002 hannibal002 approved these changes

@CalMWolfs CalMWolfs CalMWolfs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.28
Development

Successfully merging this pull request may close these issues.
4 participants
@DavidArthurCole @hannibal002 @CalMWolfs @jani270