-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend: Add backup repo #2673
Backend: Add backup repo #2673
Conversation
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/data/repo/RepoManager.kt
Conflicts have been resolved! 🎉 |
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # build.gradle.kts # buildSrc/build.gradle.kts
Conflicts have been resolved! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to test his, ive renamed the host name github.com to something else inside RepoManager.kt and deleted my local repo.
This has worked, i can join skyblock and do not get error messages in chat.
But:
/shdebug does not show anything about that. It would be good if we somewhere store that the backup repo is in use, and indicate so in /shdebug.
Also, when running /shupdaterepo
manually, i get an error message (as expected), but also the normal "updated successfully" message. maybe change the wording of that message to indicate that the internal backup repo is in use instead.
This is nothing new with my pr, but i can fix it |
patch to break github
|
Fixed some issues related to the backup repo and did the requested changes. Also removed the shdebug from the RepoManager file as there was already repo information gathered in the DebugCommand file |
What
Adds backup repo to the build. This is automatically included in every gradle build, (only adds .5mb)
This uses the exact same logic as neu uses
This aims to solve problems for people who play somewhere that github blocks them from downloading the repo, as currently all they can do is disable auto-update and manually download the repo. This results in them getting many new errors each time they update their mod version.
Repo patterns are also forced to be local while using the backup repo to avoid the edge case of a release being built before the github action to update the repo patterns completes.
This pr can be tested by deleteing your repo folder, setting your repo branch to something that isnt real and starting the game. Reading the logs will show it didnt download but you will have no repo errors and the backup repo will be copied into the repo folder.
Changelog Improvements
Changelog Technical Details