Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: empty list in compact experiment rewards #2702

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

hannibal002
Copy link
Owner

@hannibal002 hannibal002 commented Oct 9, 2024

What

Fixed an NoSuchElementException
Report: https://discord.com/channels/997079228510117908/1293485111056011294

Stack Trace
Caused by java.util.NoSuchElementException: List is empty.
    at kotlin.collections.CollectionsKt___CollectionsKt.last(_Collections.kt:418)
    at SH.features.chat.CompactExperimentRewards.sendMessage(CompactExperimentRewards.kt:92)
    at SH.features.chat.CompactExperimentRewards.onChat$lambda$2$lambda$1(CompactExperimentRewards.kt:86)
    at SH.utils.DelayedRun.checkRuns$lambda$0(DelayedRun.kt:31)
    at SH.utils.DelayedRun.checkRuns$lambda$1(DelayedRun.kt:27)
    at java.util.ArrayList.removeIf(ArrayList.java:1415)
    at SH.utils.DelayedRun.checkRuns(DelayedRun.kt:27)
    at SH.data.MinecraftData.onTick(MinecraftData.kt:74)
    at FML.common.eventhandler.EventBus.post(EventBus.java:140)

Changelog Fixes

  • Fixed an error with compact experiment rewards chat messages. - hannibal2

@hannibal002 hannibal002 added the Bug Fix Bug fixes label Oct 9, 2024
@hannibal002 hannibal002 added this to the Version 0.28 milestone Oct 9, 2024
@hannibal002 hannibal002 merged commit 4c7409c into beta Oct 9, 2024
11 checks passed
@hannibal002 hannibal002 deleted the fix-compact-experiemnt-rewards-error branch October 9, 2024 11:14
@github-actions github-actions bot removed the Bug Fix Bug fixes label Oct 9, 2024
CalMWolfs pushed a commit that referenced this pull request Oct 9, 2024
Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants