Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend: Remove more neu dependent code !!! #2738

Open
wants to merge 30 commits into
base: beta
Choose a base branch
from
Open

Backend: Remove more neu dependent code !!! #2738

wants to merge 30 commits into from
+154 −129

Conversation

NopoTheGamer
Copy link
Contributor

@NopoTheGamer NopoTheGamer commented Oct 14, 2024 •
edited by CalMWolfs
Loading

Dependencies

What

Remove more required places for neu

Images

image

Changelog Technical Details

  • Added PlatformUtils.isNeuLoaded(). - nopo
    • Moved NEU events to a wrapper.
    • Added the ability to require neu to load a module.
    • Stole the horse mixin from neu. is required for the game to launch.

Changelog Removed Features

  • Removed Fix NEU heavy pearls. - nopo
    • This was fixed in NEU.

CalMWolfs and others added 25 commits October 1, 2024 11:02
@CalMWolfs
Backend: Add skyhanni notifications
2aea746
@CalMWolfs
finish and use SkyHanniNotification
50e7a93
@CalMWolfs
display more info in the notification
faa5c81
@CalMWolfs
rename variable
3216ae7
@CalMWolfs
dont use neu button
6461aa4
@CalMWolfs
Merge branch 'refs/heads/beta' into buttoning
b1067b5 
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/misc/update/GuiOptionEditorUpdateCheck.kt
@CalMWolfs
Merge branch 'refs/heads/beta' into notifications
5c9f15e 
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/config/commands/Commands.kt
@CalMWolfs
use new command system
154319e
@CalMWolfs
Merge branch 'refs/heads/beta' into notifications
9cf9c02
@CalMWolfs
use new event name
68409ee
@NopoTheGamer
this code is nonsense rn but it will be useful in the future
1a9f9f3
@NopoTheGamer
neuapi
a5b7425
@NopoTheGamer
pv
68ed9e4
@NopoTheGamer
delete fix neu heavy pearls (neu fixed the issue like 1 week later)
c50865e
@NopoTheGamer
dont use neu for locraw + locraw command
37c092c
@NopoTheGamer
add Pseudo to neu mixin
994e440
@NopoTheGamer
add checks when using neu config
6767f77
@NopoTheGamer
calculator (this is probably weird behaviour but wtv rn
da69890
@NopoTheGamer
forgot to remove config option for the pearls
6bb14d8
@NopoTheGamer
add check to neu has focus, didnt do the todo yet
d4d3a19
@NopoTheGamer
Merge remote-tracking branch 'refs/remotes/CalMWolfs/buttoning' into …
d738048 
…remove-neus

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/utils/HypixelCommands.kt
@NopoTheGamer
Merge remote-tracking branch 'refs/remotes/CalMWolfs/notifications' i…
9c6d984 
…nto remove-neus
@NopoTheGamer
change horse mixin to be after neu (so never ?)
9e0278c
@NopoTheGamer
add sh module flag to only load if neu, rn used for using neu events
8b99634
@NopoTheGamer
fix horse again
15ee619
@github-actions github-actions bot added Backend A backend pull request that will be merged soon Wrong Title/Changelog There is an error in the title or changelog labels Oct 14, 2024
@github-actions GitHub Actions
Copy link

I have detected some issues with your pull request:

Body issues:
Change should end with a full stop in text: Moved NEU events to a wrapper
Change should end with a full stop in text: Added the ability to require neu to load a module
Change should end with a full stop in text: Stole the horse mixin from neu. is required for the game to launch
Change should end with a full stop in text: This was useless

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Oct 14, 2024
@hannibal002 hannibal002 added this to the Version 0.28 milestone Oct 14, 2024
@hannibal002
Copy link
Owner

have not yet looked at the code changes in this pr.
just one thin give noticed so far:

heavy pearl detectoin

image
Either this is not yet fixed in NEU 2.4.0, or neu's detection happens after SkyHanni's fix.
I will tomorrow try with the sh fix disabled, to see if neu on its own actually detects it.
(the reason I'm confused here is that SkyHanni already checks the last neu detection time, and only shows the chat message if the fix is necessary, and we detect it via sack change/item in inventory add, and this should happen very late, compared to neu's earlier solutions to detect the heavy pearl pickup.

@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 16, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 16, 2024
@NopoTheGamer
Copy link
Contributor Author

NopoTheGamer commented Oct 16, 2024 •
edited
Loading

heavy pearl detection

it works i guess just not as fast

2024-10-17.09-03-52.-.Trim.mp4

it took so long because the box was a bit small I've made a pr to make it a bit bigger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalMWolfs CalMWolfs CalMWolfs approved these changes

Assignees
No one assigned
Labels
Backend A backend pull request that will be merged soon
Projects
None yet
Milestone
Version 0.28
Development

Successfully merging this pull request may close these issues.
3 participants
@NopoTheGamer @hannibal002 @CalMWolfs