Fix: Fel Highlight in Edge Case #2746
Conversation
| @@ -83,7 +83,7 @@ object DungeonMobManager { | |||
| fun onRenderWorld(event: LorenzRenderWorldEvent) { | |||
| if (!fel.highlight.get()) return | |||
| if (fel.line) { | |||
| felOnTheGround.filter { it.canBeSeen() }.forEach { | |||
| felOnTheGround.filter { it.canBeSeen() && it.distanceToPlayer() < 30 }.forEach { | |||
There was a problem hiding this comment.
is the distance check really needed? since mob detection already has a distance limit in which it works
There was a problem hiding this comment.
The canBeSeen logic gets sketchy at high distance in complex terrain like dungeons. I had at least two instances where it would be unrealistic to see fels (1 to 2 pixels where only visible).
There was a problem hiding this comment.
The issue happens when the mob gets detected in range and then you move away from the mob. Since then distances can go up to 60 blocks. The 30 is just a value I find appropriate since it is the usable view distance. Sure there are some cases where it is oversensitive (mostly at vertical rooms). Btw. 24 is the Range for the detection.
There was a problem hiding this comment.
please add support for distance check inside the canBeSeen function
There was a problem hiding this comment.
There is 80 blocks. And it is no Problem for anything else. Just the line inside dungeons.
There was a problem hiding this comment.
what 80 blocks do you mean? is this a reply to my message above?
hannibal002
added
the
Soon
What
Mobs may become only later on invisble. So I added the check on each render call. Very much a detriment to performance but ok.
Also added a Invisible Info for \shcopyentities.
Changelog Fixes