Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/Improvement: Live Contest Stats #839

Draft
wants to merge 35 commits into
base: beta
Choose a base branch
from
Draft

Feature/Improvement: Live Contest Stats #839

wants to merge 35 commits into from
+216 −28

Conversation

Obsidianninja11
Copy link
Contributor

@Obsidianninja11 Obsidianninja11 commented Dec 27, 2023 •
edited
Loading

What

Adds an option to show a gui with contest stats during contest.
The estimated position doesn't work anymore because hypixel removed that data from the tablist

Images

image

Changelog New Features

  • Option to show a gui with contest stats during contest. - Obsidian

@Obsidianninja11
Copy link
Contributor Author

Obsidianninja11 commented Dec 27, 2023 •
edited
Loading

btw, here's what i'm testing the regex ( (Collected|(?<medal>§b§lDIAMOND|§3§lPLATINUM|§6§lGOLD|§f§lSILVER|§c§lBRONZE) §fwith) §e(?<amount>.+)) on:
§c§lBRONZE §fwith §e65,814

which is the data that the game is testing it on, but it doesn't work in game, but does in regex101 asofub asoufb aos

@Obsidianninja11
Copy link
Contributor Author

ok its magically working now

@Obsidianninja11 Obsidianninja11 marked this pull request as ready for review December 28, 2023 02:45
@Obsidianninja11 Obsidianninja11 changed the title wip live contest stats Live Contest Stats Dec 28, 2023
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Dec 28, 2023
@hannibal002 hannibal002 added this to the Version 0.23 milestone Dec 28, 2023
@Obsidianninja11
Copy link
Contributor Author

Ah figured out why the predicted score sometimes sucks.
New commit soon

@Obsidianninja11 Obsidianninja11 mentioned this pull request Dec 31, 2023
Closed
@Obsidianninja11
Copy link
Contributor Author

Obsidianninja11 commented Jan 5, 2024 •
edited
Loading

I'm not quite happy with the start time stuff yet
It's still a little buggy

maybe i should switch back to time participated?
I don't find this as useful though

@Obsidianninja11 Obsidianninja11 marked this pull request as draft January 15, 2024 00:49
@hannibal002 hannibal002 removed the Soon This Pull Request will be merged within the next couple of betas label Jan 15, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Apr 15, 2024
@Obsidianninja11
Merge branch 'beta' into jacob-contest-live-stats
5f93e21 
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/config/features/garden/GardenConfig.java
@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Apr 17, 2024
@hannibal002 hannibal002 removed this from the Version 0.26 milestone May 8, 2024
@Obsidianninja11 Obsidianninja11 mentioned this pull request May 29, 2024
Open
@Obsidianninja11
Copy link
Contributor Author

I think this might just need a bit of code cleanup.
I do want to use less duplicate code for making the GUI list and the end of contest messages
When I was testing it, it seemed to work fine with swapping contests.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jun 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@CalMWolfs
Merge branch 'refs/heads/beta' into fork/Obsidianninja11/jacob-contes…
4190bbb 
…t-live-stats

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/garden/contest/JacobContestStatsSummary.kt
@CalMWolfs
fix merge
fc91b2f
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jun 6, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Aug 13, 2024
@Obsidianninja11
Merge branch 'beta' into jacob-contest-live-stats
9860066 
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/config/features/garden/GardenConfig.java
#	src/main/java/at/hannibal2/skyhanni/features/garden/contest/JacobContestStatsSummary.kt
#	src/main/java/at/hannibal2/skyhanni/utils/LorenzUtils.kt
@Obsidianninja11
Translator fix and sort of rewrite
059d884
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

Conflicts have been resolved! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j10a1n15 j10a1n15 j10a1n15 left review comments

@CalMWolfs CalMWolfs Awaiting requested review from CalMWolfs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Obsidianninja11 @j10a1n15 @CalMWolfs @hannibal002