chore: clean codes

hantsy · Dec 23, 2023 · 2aadff2 · 2aadff2
1 parent f65c6d1
commit 2aadff2
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/hibernate-reactive-mutiny-oracle/docker-compose.yml b/hibernate-reactive-mutiny-oracle/docker-compose.yml
@@ -3,12 +3,12 @@ version: '3.7' # specify docker-compose version
 services:
   oracle:
     # see https://www.oracle.com/database/technologies/appdev/xe.html
-    image: gvenzl/oracle-xe:21.3.0-slim
+    image: gvenzl/oracle-free:23-slim
     ports:
       - "1521:1521"
     restart: always
     environment:
-      ORACLE_PASSWORD: password
+      ORACLE_PASSWORD: sysPassword
       ORACLE_DATABASE: blogdb
       APP_USER: testUser
       APP_USER_PASSWORD: testPassword

diff --git a/hibernate-reactive-mutiny-oracle/src/main/resources/schema.sql b/hibernate-reactive-mutiny-oracle/src/main/resources/schema.sql
@@ -1,8 +1,8 @@
 CREATE SEQUENCE todos_seq START WITH 1;
-
+-- 23c supports `if not exists`
 CREATE TABLE IF NOT EXISTS todos
 (
-    id    NUMBER  DEFAULT todos_seq.nextval NOT NULL,
+    id    NUMBER(10)  DEFAULT todos_seq.nextval NOT NULL,
     title VARCHAR2(200)
 );
 

diff --git a/hibernate-reactive-mutiny-oracle/src/test/java/com/example/demo/TodoRepositoryTest.java b/hibernate-reactive-mutiny-oracle/src/test/java/com/example/demo/TodoRepositoryTest.java
@@ -28,7 +28,7 @@ public class TodoRepositoryTest {
 
     // see: https://java.testcontainers.org/modules/databases/oraclexe/
     @Container
-    static OracleContainer oracleContainer = new OracleContainer("gvenzl/oracle-xe:21-slim-faststart")
+    static OracleContainer oracleContainer = new OracleContainer("gvenzl/oracle-free:23-slim-faststart")
         .withDatabaseName("blogdb")
         .withUsername("testUser")
         .withPassword("testPassword");
@@ -56,7 +56,7 @@ public void setup() {
     }
 
     @Test
-    public void testPostRepositoryExisted() {
+    public void testTodosRepositoryExisted() {
         assertNotNull(todos);
     }