Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework tests to not use @hapi/joi@15 #4539

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rework tests to not use @hapi/joi@15 #4539

wants to merge 1 commit into from

Conversation

kanongil
Copy link
Contributor

@kanongil kanongil commented Jan 19, 2025 •
edited
Loading

Same as #4474, except applied against master branch.

Closes #4474.

@kanongil kanongil added the test Test or coverage label Jan 19, 2025
@kanongil kanongil mentioned this pull request Jan 19, 2025
Open
@Marsup
Copy link
Contributor

Marsup commented Mar 1, 2025

Sorry, I'm late to this one, but why target master additionally to the next branch? Do you actually want it in a non-breaking release?

@kanongil
Copy link
Contributor Author

kanongil commented Mar 1, 2025 •
edited
Loading

Sorry, I'm late to this one, but why target master additionally to the next branch? Do you actually want it in a non-breaking release?

Sure. This now just changes the testing infrastructure to not rely on the old Joi release.

Feel free to just merge it into next, if you think that works better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damusix damusix damusix approved these changes

Assignees
No one assigned
Labels
test Test or coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kanongil @Marsup @damusix