Replace unmaintained useragent dependency with my-ua-parser

[johnwatson484]

useragent is no longer actively maintained and has several outstanding vulnerabilities within itself and an outdated version of tmp.

[damusix]

@johnwatson484 Would it be too much to ask if perhaps you could add type augmentations? And, if you could improve this plugin by make it more ergonomic for developer use, how would you do it? Now would be the best time. It might be as simple as server.decorate('request', 'userAgent', function() { return this.plugins.scooter }. With type augmentations, of couse!

Just some thoughts, not required. If you want some references: https://github.com/hapijs/hapi/blob/master/typescript.md#typed-plugin-decorations

[johnwatson484]

@johnwatson484 Would it be too much to ask if perhaps you could add type augmentations? And, if you could improve this plugin by make it more ergonomic for developer use, how would you do it? Now would be the best time. It might be as simple as server.decorate('request', 'userAgent', function() { return this.plugins.scooter }. With type augmentations, of couse!

Just some thoughts, not required. If you want some references: https://github.com/hapijs/hapi/blob/master/typescript.md#typed-plugin-decorations

Yeah good idea. Happy to do that.

I think the sever decoration function is a good idea. Makes it a bit more intuitive and aligns well with approaches taken in other Hapi plugins.

I've declared the types in a file similar to other Hapi plugins.

Let me know what you think about the approaches I've taken.

[damusix]

@Marsup your blessing good sir

[Marsup]

Looks good, but I wouldn't necessarily pin the dependency's version.

[johnwatson484]

Looks good, but I wouldn't necessarily pin the dependency's version.

@Marsup - Unpinned 😁