Skip to content

don't terminate webpack process in watch mode #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

don't terminate webpack process in watch mode #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,15 @@ FlowWebpackPlugin.prototype.apply = function(compiler: Compiler) {
const plugin = this

let flowResult: CompleteFlowResult
let flowExecutionError: any = undefined;

const runCallback = failOnError =>
(compiler, webpackCallback) => {
let flowExecutionError: any = undefined
let inWatchMode: boolean = false

const runCallback = watchMode => {
inWatchMode = watchMode
let failOnError = inWatchMode ?
plugin.options.failOnErrorWatch :
plugin.options.failOnError
return (compiler, webpackCallback) => {
flowCheck()
.then(result => {
flowResult = result
Expand All @@ -93,6 +98,7 @@ FlowWebpackPlugin.prototype.apply = function(compiler: Compiler) {
failOnError ? webpackCallback('Flow execution failed. ' + error) : webpackCallback()
})
}
}

compiler.plugin('after-emit', (compilation, callback) => {
const reportingCollectionName = REPORTING_SEVERITY[plugin.options.reportingSeverity]
Expand Down Expand Up @@ -122,8 +128,8 @@ FlowWebpackPlugin.prototype.apply = function(compiler: Compiler) {
* * to be done before or at time of 'compilation callback' - to avoid expensive compilation when type error present
* * hook needs to be asynchronous
*/
compiler.plugin('run', runCallback(plugin.options.failOnError))
compiler.plugin('watch-run', runCallback(plugin.options.failOnErrorWatch))
compiler.plugin('run', runCallback(false))
compiler.plugin('watch-run', runCallback(true))

function callUserCallback(webpackCallback: (?mixed) => void) {
let userCallbackResult
Expand Down Expand Up @@ -154,7 +160,7 @@ FlowWebpackPlugin.prototype.apply = function(compiler: Compiler) {
}

function afterUserCallback(webpackCallback: (?mixed) => void) {
if (!flowResult.successful && plugin.options.failOnError) {
if (!flowResult.successful && plugin.options.failOnError && !inWatchMode) {
const details = plugin.options.printFlowOutput ? (EOL + formatFlowOutput(flowResult)) : ''

/*
Expand Down